counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
data-dwh-dbt-project/models/intermediate/core
History
Pablo Martin 20477dcc2c Merged PR 5447: Fix GJ Payments consistency with VRs 
# Description

We're getting Data Alerts triggered for Guest Journey payments with no id for the guest. This is because we have payments in the DWH for which we still don't have the related Verification Request in the DWH as well.

This PR changes a `LEFT JOIN` with the verification request table into an `INNER JOIN`, effectively making it impossible for a payment to not have user data if the VR is not there.

We increase data latency (the payment won't show up until the related VR is in the DWH) but we win consistency (no orphan payments without their full details).

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

change left join to inner join
2025-06-12 08:06:08 +00:00
..
int_core__ab_test_monitoring_guest_journey.sql Merged PR 5187: Switch models that use int_core__verification_payments 2025-05-12 15:58:53 +00:00
int_core__ab_test_tracking_guest_journey.sql Merged PR 3766: First version of ab_test_tracking_guest_journey 2024-12-04 07:58:14 +00:00
int_core__accommodation.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__accommodation_to_product_bundle.sql addressed comments 2025-06-10 14:42:59 +02:00
int_core__accommodations_activity.sql Listings report model 2025-02-03 10:37:25 +01:00
int_core__active_property_managers_system.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__booking_charge_events.sql Merged PR 2642: Booking Charge Events to have a similar logic as invoicing 2024-09-03 13:15:40 +00:00
int_core__booking_details.sql Merged PR 5187: Switch models that use int_core__verification_payments 2025-05-12 15:58:53 +00:00
int_core__booking_service_detail.sql Merged PR 5187: Switch models that use int_core__verification_payments 2025-05-12 15:58:53 +00:00
int_core__booking_to_product_bundle.sql Merged PR 3539: Normalise service names and create booking to service table 2024-11-15 10:04:02 +00:00
int_core__booking_to_service.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__bookings.sql Merged PR 5429: Rework Booking Source in int_core__bookings 2025-06-10 14:38:35 +00:00
int_core__check_in_cover_listings.sql fixed testing for core__check_in_cover_listings 2024-08-28 10:47:31 +02:00
int_core__check_in_cover_prices.sql Merged PR 2865: Propagate tax exclusive check in hero payments 2024-09-17 07:25:09 +00:00
int_core__check_in_cover_users_v1.sql rename model to make version name explicit 2025-06-10 12:43:49 +02:00
int_core__check_in_cover_users_v2.sql removed unused upstream models 2025-06-04 10:53:24 +02:00
int_core__check_in_hero_users.sql Added booking fee and currency to model 2025-01-15 09:00:36 +01:00
int_core__country.sql Merged PR 2077: Adding Country to intermediate 2024-06-19 15:34:15 +00:00
int_core__deal.sql Merged PR 4618: Bugfix - Ensure the PMS is active 2025-03-05 14:57:57 +00:00
int_core__duplicate_bookings.sql Thanks Uri for the catch, then when id_user_guest is NULL it won't be considered a duplicate. 2024-07-31 16:23:27 +02:00
int_core__guest_journey_payments.sql Merged PR 5214: Integrates Guest Product new flow Payments 2025-05-15 07:00:11 +00:00
int_core__guest_product_payments_v2.sql Merged PR 5447: Fix GJ Payments consistency with VRs 2025-06-12 08:06:08 +00:00
int_core__guest_product_price_plans.sql Removes configuration status and adds config id for further joins 2025-03-18 09:20:31 +01:00
int_core__guest_products.sql Merged PR 4699: Creates a master table for guest products 2025-03-14 13:04:46 +00:00
int_core__guest_satisfaction_responses.sql Merged PR 5187: Switch models that use int_core__verification_payments 2025-05-12 15:58:53 +00:00
int_core__host_booking_fees.sql Merged PR 2725: Force id user field to lower in staging 2024-09-03 14:36:21 +00:00
int_core__invoicing_price_plans_per_month.sql Merged PR 2642: Booking Charge Events to have a similar logic as invoicing 2024-09-03 13:15:40 +00:00
int_core__new_dash_deal_since_date.sql Merged PR 4349: Xero metrics by Business Scope 2025-02-11 15:13:42 +00:00
int_core__new_dash_user_overview.sql changed names 2025-06-10 14:20:28 +02:00
int_core__new_dash_users.sql Merged PR 3491: Allows possibility to retrieve claim as date or timestamp 2024-11-13 11:42:04 +00:00
int_core__payaway.sql model and docs 2024-09-17 12:16:52 +02:00
int_core__payaway_per_month_user.sql model and docs+tests 2024-09-17 15:47:45 +02:00
int_core__payments.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__price_plans.sql docs and moving stuff 2024-04-08 09:44:32 +02:00
int_core__product_service_billing_item.sql Merged PR 3638: Propagates billing info to booking service detail and booking summary 2024-11-22 13:50:30 +00:00
int_core__product_service_to_price.sql Merged PR 3578: First version of int_core__booking_service_detail 2024-11-19 08:24:32 +00:00
int_core__protection_plan_billing_item.sql Merged PR 3638: Propagates billing info to booking service detail and booking summary 2024-11-22 13:50:30 +00:00
int_core__protection_plan_cover.sql Merged PR 3539: Normalise service names and create booking to service table 2024-11-15 10:04:02 +00:00
int_core__protection_plan_to_price.sql Merged PR 3578: First version of int_core__booking_service_detail 2024-11-19 08:24:32 +00:00
int_core__screen_and_protect_users.sql Invoice model completed 2025-02-13 15:31:22 +01:00
int_core__unified_user.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__unique_accommodation_to_user.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__user_host.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__user_product_bundle.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__user_product_bundle_contains_services.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__user_role.sql Merged PR 2516: Create host_user and user_role in intermediate 2024-08-07 14:28:34 +00:00
int_core__user_test_account.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__verification_product_payments.sql Merged PR 5182: First version of Guest Journey Payments 2025-05-12 09:25:54 +00:00
int_core__verification_request_booking_source.sql Removed guests_id and modified query structure 2024-07-11 16:49:24 +02:00
int_core__verification_request_completed_date.sql Merged PR 2028: guest journey estimated completed date 2024-06-13 13:30:22 +00:00
int_core__verification_request_completeness.sql Merged PR 2020: Verification request completeness for intermediate steps + schema documentation 2024-06-13 08:14:11 +00:00
int_core__verification_requests.sql Merged PR 5403: Removes test accounts 2025-06-06 12:17:49 +00:00
int_core__vr_check_in_cover.sql missing filter to avoid new vrs appearing in the old cte 2025-06-10 16:35:16 +02:00
int_core__waiver_fees.sql ***ing decimals 2025-02-11 17:10:07 +01:00
schema.yml Merged PR 5429: Rework Booking Source in int_core__bookings 2025-06-10 14:38:35 +00:00