20477dcc2c
# Description We're getting Data Alerts triggered for Guest Journey payments with no id for the guest. This is because we have payments in the DWH for which we still don't have the related Verification Request in the DWH as well. This PR changes a `LEFT JOIN` with the verification request table into an `INNER JOIN`, effectively making it impossible for a payment to not have user data if the VR is not there. We increase data latency (the payment won't show up until the related VR is in the DWH) but we win consistency (no orphan payments without their full details). # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. change left join to inner join |
||
|---|---|---|
| .. | ||
| athena | ||
| check_in_hero | ||
| core | ||
| cross | ||
| edeposit | ||
| hubspot | ||
| kpis | ||
| resolutions | ||
| screen_and_protect | ||
| xero | ||