sh-notion/notion_data_team_no_files/20250414 Old Dash Invoicing - Exclude New Dash dat 1d50446ff9c9807aa1edcca0c9e97082.md
Pablo Martin a256b48b01 pages
2025-07-11 16:15:17 +02:00

60 lines
No EOL
2.8 KiB
Markdown
Raw Permalink Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

# 20250414 Old Dash Invoicing - Exclude New Dash data
# Problem
On Wednesday 9th April, an issue concerning Old Dash invoicing was raised in the form of a Data Request. It appears that `34647958964 - Sedona RocksVacation Rentals` have had New Dash Bookings appearing in the Old Dash invoicing exports that Data Team generates.
According to Lisa, a similar issue happens at least with 4 other accounts.
# Current State
No exclusion of New Dash data is handled in the Invoicing Exporter tool.
Current invoiceable items in Old Dash Invoicing are:
- Bookings
- Listings
- Verifications
- Waivers (for Host-takes-risk, revenue share)
# Final Solution
For Old Dash invoicing:
**Modify:**
- Bookings that appear in `BookingToProductBundle` need to be excluded.
**Investigate:**
- To verify how to handle Verification Fees - although theres not too many accounts.
**Keep as is:**
- Users that migrate to New Dash are NOT supposed to be excluded.
- Listing logic remains the same. Migrated accounts would naturally show a listing fee of 0.
- Waiver logic remains the same. This would need to be likely excluded in the future for host-takes-risk revenue share once implemented in Hyperline for New Dash accounts.
Lastly, Data Team will not re-do previous invoicing exports. These will be handled manually by Finance team. The final solution is expected to be in place for the next invoicing cycle, beginning May 2025.
# Solution Discussion
1. Ideally, exclude Users that have been migrated to New Dash
- No invoice file would be generated, thus all items would be excluded.
- What happens on the transition of a User being migrated from Old Dash to New Dash?
→ It cannot be done by excluding users as proposed here because:
- It would remove Bookings that are not migrated to New Dash that might still need billing.
- It would remove Waivers. Its not clear though that the old PayAway logic would still apply for New Dash users as these should rely on the service (Basic Waiver vs. Waiver Plus). To be handled differently, as it needs to be implemented in Hyperline, as a separated line of work. We keep as is.
2. If not possible, how can we exclude:
- Bookings: if a Booking appears in `BookingToProductBundle`, exclude.
- It was also suggested to use IsLegacy but wouldnt work:
- ~~For migrated users:~~
- ~~IsLegacy = False → New Dash~~
- ~~IsLegacy = True → Old Dash~~
- ~~for NOT migrated users:~~
- ~~IsLegacy = False → Old Dash~~
- Listings: when a user is migrated to new dash, fee is set to 0 - Nothing to do on Data side.
- Verifications: to be checked on Data side → 7 or 8 accounts; if its too much work it can be done manually on Finance side.
- Waivers: as is, to be handled separately in the future.