counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
data-dwh-dbt-project/seeds/stg_seed__accounting_aggregations.csv
Oriol Roqué Paniagua f799a8d30f Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 
# Description

Booking fees is widely used with different meanings, for old dash, for new dash, for both, etc. This is painful. First step to align on a proper naming is ensure that what we report in Main KPIs is clearly stated, which in this case, Booking Fees are now called Old Dashboard Booking Fees.

Changes:
* Modify `stg_seed__accounting_aggregations` seed to rename Booking Fees to Old Dashboard Booking Fees. This is for us to clarify. This is only applied for KPIs compute. I also added an empty space that I mistakenly forgot in the past for `financial_l3_aggregation`.
* Modify KPIs source, i.e., `int_kpis__metric_daily_invoiced_revenue`. Here I forcefully modify the name of the field to `xero_old_dashboard_booking_net_fees_in_gbp`.
* Propagate changes of downstream usages of `xero_booking_net_fees_in_gbp` to `xero_old_dashboard_booking_net_fees_in_gbp`. This affects all models, including the reporting model. On this one we still have both names to avoid breaking it. I will need to modify the data glossary in PBI anyway so I'll do this change as well.
* Modify displayed metric name from Booking Fees Revenue to Old Dashboard Booking Fees Revenue.
* Modify schema so it reflects the proper names, descriptions, and tests.
* Ensure outlier and completion tests still work after this change.

I confirm the field `xero_booking_net_fees_in_gbp` does not exist anymore in the rest of DWH after these changes, except for the abovementioned comment on the reporting line.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #28560
2025-03-18 14:55:32 +00:00

4.5 KiB
Raw Blame History

1account_coderoot_aggregationkpis_aggregationfinancial_l1_aggregationfinancial_l2_aggregationfinancial_l3_aggregation
2200Other Invoiced RevenueUnknown1-Guest Screening and Protection10-Other Invoiced Revenue100-Other Invoiced Revenue
3201Damage Waiver FeesAccounting Guest Revenue2-Deposit Management21-Deposit Management Services210-Damage Waiver Fees
4202Deposit FeesAccounting Guest Revenue2-Deposit Management21-Deposit Management Services211-Deposit Fees
5203Verification FeesInvoiced Operator Revenue1-Guest Screening and Protection13-Verification Fees131-Verification Fees
6204Listing FeesInvoiced Operator Revenue1-Guest Screening and Protection12-Listing Fees121-Listing Fees
7206Old Dashboard Booking FeesInvoiced Operator Revenue1-Guest Screening and Protection11-Booking Fees111-Booking Fees
8207Listing FeesInvoiced Operator Revenue1-Guest Screening and Protection12-Listing Fees121-Listing Fees
9208Old Dashboard Booking FeesInvoiced Operator Revenue1-Guest Screening and Protection11-Booking Fees111-Booking Fees
10209Listing FeesInvoiced Operator Revenue1-Guest Screening and Protection12-Listing Fees121-Listing Fees
11210Old Dashboard Booking FeesInvoiced Operator Revenue1-Guest Screening and Protection11-Booking Fees111-Booking Fees
12211Listing FeesInvoiced Operator Revenue1-Guest Screening and Protection12-Listing Fees121-Listing Fees
13212Old Dashboard Booking FeesInvoiced Operator Revenue1-Guest Screening and Protection11-Booking Fees111-Booking Fees
14213Listing FeesInvoiced Operator Revenue1-Guest Screening and Protection12-Listing Fees121-Listing Fees
15214Old Dashboard Booking FeesInvoiced Operator Revenue1-Guest Screening and Protection11-Booking Fees111-Booking Fees
16215Listing FeesInvoiced Operator Revenue1-Guest Screening and Protection12-Listing Fees121-Listing Fees
17216Old Dashboard Booking FeesInvoiced Operator Revenue1-Guest Screening and Protection11-Booking Fees111-Booking Fees
18217Deposit FeesAccounting Guest Revenue2-Deposit Management21-Deposit Management Services211-Deposit Fees
19218Damage Waiver FeesAccounting Guest Revenue2-Deposit Management21-Deposit Management Services210-Damage Waiver Fees
20219Athena APIInvoiced API Revenue1-Guest Screening and Protection14-Athena API141-Athena API
21220E-Deposit APIInvoiced API Revenue1-Guest Screening and Protection15-E-Deposit API151-E-Deposit API
22221Guesty ResolutionsInvoiced API Revenue4-Mediation and Resolution41-Guesty Resolutions411-Guesty Resolutions
23222Check In CoverAccounting Guest Revenue3-Guest Products31-Check In Cover311-Check In Cover
24223Check In CoverAccounting Guest Revenue3-Guest Products31-Check In Cover311-Check In Cover
25227Basic ProtectionInvoiced Operator Revenue1-Guest Screening and Protection17-Protection Services171-Basic Protection
26228Waiver ProInvoiced Operator Revenue2-Deposit Management21-Deposit Management Services213-Waiver Pro
27229Id VerificationInvoiced Operator Revenue1-Guest Screening and Protection16-Screening Services163-Id Verification
28230Protection PlusInvoiced Operator Revenue1-Guest Screening and Protection17-Protection Services172-Protection Plus
29231Screening PlusInvoiced Operator Revenue1-Guest Screening and Protection16-Screening Services162-Screening Plus
30232Sex Offenders CheckInvoiced Operator Revenue1-Guest Screening and Protection16-Screening Services164-Sex Offenders Checks
31233Protection ProInvoiced Operator Revenue1-Guest Screening and Protection17-Protection Services173-Protection Pro
32234Basic ScreeningInvoiced Operator Revenue1-Guest Screening and Protection16-Screening Services161-Basic Screening
33235Resolution Process for Protection ServicesAccounting Resolutions1-Guest Screening and Protection17-Protection Services174-Resolution Process for Protection Services
34236Basic WaiverAccounting Guest Revenue2-Deposit Management21-Deposit Management Services211-Basic Waiver
35237Waiver PlusAccounting Guest Revenue2-Deposit Management21-Deposit Management Services212-Waiver Plus
36238Basic Damage DepositAccounting Guest Revenue2-Deposit Management21-Deposit Management Services214-Basic Damage Deposit
37239Resolution Process for Deposit Management ServicesAccounting Resolutions2-Deposit Management21-Deposit Management Services215-Resolution Process for Deposit Management Services
38301Damage Host-Waiver PaymentsDamage Host-Waiver Payments5-Damage Host-Waiver Payments51-Damage Host-Waiver Payments511-Damage Host-Waiver Payments