Commit graph

1422 commits

Author SHA1 Message Date
Joaquin Ossa
3b6f6eed0a Listings report model 2025-02-03 10:37:25 +01:00
Oriol Roqué Paniagua
353972984e Merged PR 4236: Propagate contact name for reporting purposes only
# Description

Propagates contact name and id_deal + contact name combination for PBI in xero - sales monthly trends

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Propagate contact name for reporting purposes only

Related work items: #26618
2025-01-31 09:53:54 +00:00
Joaquin Ossa
f55c618cfa Merged PR 4234: Fixed filter in mrr
# Description

Fixed filter in MRR metrics, now it only filters current month

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Fixed filter in mrr

Related work items: #27180
2025-01-31 09:40:25 +00:00
Joaquin Ossa
8fdabf1cb4 Fixed filter in mrr 2025-01-31 10:37:03 +01:00
Oriol Roqué Paniagua
68952223ca Merged PR 4228: First version of sales - monthly trends
# Description

New model that aggregates in a monthly basis the information from Xero sales. The aggregation is done by several categories, most of them to be included as filters in PBI. Metrics represent the amount without taxes in: 1) the current month, 2) the previous month, 3) twelve months ago, 4) current year YTD (fiscal year) and 5) previous year YTD (fiscal year).

It also propagates the model to reporting

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models. **I was hesitating between table or view. Table should speed up tests, but I intend to create a reporting table with a similar structure so probably a bit of waste of space. Anyway, not a big deal now**

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #26618
2025-01-31 08:33:15 +00:00
Joaquin Ossa
d793f610c9 Merged PR 4232: Update rule for metric depends on invoicing
# Description

Update rule for when to display metrics that depend on invoicing cycle.
Now they will show previous month values from the 20th onward of the current month

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [x] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Update rule for metric depends on invoicing

Related work items: #27180
2025-01-31 08:32:35 +00:00
Joaquin Ossa
1f95d0ee6b Merged PR 4231: Changed MRR logic
# Description

Changed the MRR way of being considered, now it uses for the ongoing month the revenue of the 12 months previous to that one.
Not both MRR metrics will only not show in the current month.
Changed the rule for metrics depending on invoicing so that they show the previous month value from the 20th onward of the current month

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [x] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #26820
2025-01-31 08:32:21 +00:00
Joaquin Ossa
696ac24e35 updated monthly_aggregated_metrics_history_by_deal 2025-01-30 17:18:08 +01:00
Joaquin Ossa
1e37d04f72 Update rule for metric depends on invoicing 2025-01-30 16:51:35 +01:00
Joaquin Ossa
7ada9de3a1 Added comments 2025-01-30 16:34:27 +01:00
Joaquin Ossa
40c8e20e70 Addressed comments 2025-01-30 16:30:03 +01:00
Joaquin Ossa
bb9dea8ed6 Removed changes for cutoff date 2025-01-30 16:18:29 +01:00
Joaquin Ossa
396d19b549 changed exclusion rule for metrics depending on invoicing 2025-01-30 15:43:53 +01:00
Joaquin Ossa
142b5a526f MRR change 2025-01-30 15:15:34 +01:00
Oriol Roqué Paniagua
a208541e04 Merged PR 4224: Rework accounting aggregations for Financial Reporting
# Description

This PR reworks the Financial Aggregations based on Nathan's requirements, that can be found in an Excel attached to the board ticket.

Main changes:
- Accounting seed now contains 3 financial aggregations as requested by Finance
- These 3 aggregations are propagated up to reporting. This effectively breaks a WIP report - but it's WIP, not in prod, so it's not a big deal

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [X] Check if a full-refresh is required after this PR is merged. **Need to create the seed manually**

Related work items: #26618
2025-01-30 10:28:49 +00:00
Joaquin Ossa
491cf2743e Merged PR 4223: Cleaned first time booked for deals
# Description

Cleaned first time booked for deals.
Removed fields from models that were previously using it and from schema

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Cleaned first time booked for deals

Related work items: #27121
2025-01-30 09:23:31 +00:00
Joaquin Ossa
fe317ac17a Cleaned first time booked for deals 2025-01-30 10:16:29 +01:00
Joaquin Ossa
62cecf52f0 Merged PR 4202: New expected MRR metric
# Description

Sorry for this PR, it ended up having a lot of changes. I'll try to list them to make it as clear as possible.
- **int_monthly_onboarding_mrr_per_deal: **This model was changed to obtain all values of `expected_onboarding_mrr_per_deal` for our used dimensions.
- **int_mtd_agg_onboarding_mrr_revenue: **This model obtains the `expected_onboarding_mrr_revenue` for dimension `per_number_of_listings` and `global` which is obtained by adding the values from the first one.
- **int_mtd_aggregated_metrics: ** Removed the `first_time_booked_deals` metric, renamed the `expected_mrr` to `expected_mrr_per_deal` and added `expected_mrr` for the total revenue expected
- **int_mtd_vs_previous_year_metrics: ** removed the `first_time_booked_deals` metric and added the new MRR metrics. Changed how this was being computed, previously it was being done in this same model now it gets them directly from both onboarding_mrr models
- **int_kpis__lifecycle_daily_deal: ** Included all deals in HubSpot and used the `live_date_utc` as the date when deals go live, unless the deal is not in HubSpot then it uses the `created_date_utc` from core
- **int_kpis__metric_daily_deals: ** Changed the logic for `New Deals` so it uses `hubspot_listing_segmentation` instead of `active_accommodations_per_deal_segmentation` like the others states of the deal_lifecycle

**the package-dock.yml need to rebase**

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

New expected MRR metric

Related work items: #26820
2025-01-29 16:07:42 +00:00
Joaquin Ossa
63b1eac81f Addressed comments 2025-01-29 17:06:37 +01:00
Joaquin Ossa
a48f6d0f59 Fixed dumb auto formatting 2025-01-29 17:06:37 +01:00
Joaquin Ossa
c0da375223 Update 2025-01-29 17:06:37 +01:00
Joaquin Ossa
26898322e7 wip fixing deals from hubspot 2025-01-29 17:06:37 +01:00
Joaquin Ossa
cf024f7b71 wip 2025-01-29 17:06:37 +01:00
Joaquin Ossa
cea7cdb34d Removed first_time_booked_deals metric 2025-01-29 17:06:37 +01:00
Joaquin Ossa
88e86ea9ed Added schema 2025-01-29 17:06:37 +01:00
Joaquin Ossa
8bd5851235 created new model to get all mrr metrics 2025-01-29 17:06:37 +01:00
Joaquin Ossa
39de8617b7 New expected MRR metric 2025-01-29 17:06:37 +01:00
Oriol Roqué Paniagua
6dcfe03b30 Merged PR 4215: Fixes
# Description

Small PR to fix stuff

# Checklist

- [ ] The edited models and dependants run properly with production data.
- [ ] The edited models are sufficiently documented.
- [ ] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Fixes

Related work items: #27096
2025-01-29 12:46:53 +00:00
Joaquin Ossa
4ed59ffd15 Merged PR 4198: Update Onboarding MRR and Deal Lifecycle
# Description

Changed the name to `Expected Onboarding MRR per New Account` and removed deals lifecycle `Frist Booked`

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #26820
2025-01-27 14:10:44 +00:00
Joaquin Ossa
d7f454b326 Removed deal lifecycle First-Booked 2025-01-27 14:55:53 +01:00
Joaquin Ossa
5186cd2cac Renamed Onboarding MRR per New Account 2025-01-27 12:40:52 +01:00
Joaquin Ossa
952e861bad Merged PR 4171: Capped new ratios
# Description

Modified macro `calculate_safe_relative_increment` to check if the metric is any of the new ratios then it would cap them between -1 and 1.
This is the best way I came up with so the code is not too crazy, what do you think??

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Capped new ratios

Related work items: #26792
2025-01-24 13:59:59 +00:00
Joaquin Ossa
e63a093991 Added ratios to deal models 2025-01-24 14:47:41 +01:00
Joaquin Ossa
720185f235 Fixed macro 2025-01-24 14:17:29 +01:00
Joaquin Ossa
e4d19b85e8 Capped new ratios 2025-01-24 11:36:22 +01:00
Joaquin Ossa
0df6d07c20 Merged PR 4166: New KPI rates for Main KPIs
# Description

New KPI rates for Main KPIs

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [x] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

New KPI rates for Main KPIs

Related work items: #26792
2025-01-24 08:11:45 +00:00
Joaquin Ossa
f7bacc2310 changed names 2025-01-24 08:30:05 +01:00
Joaquin Ossa
49a10fe249 New KPI rates for Main KPIs 2025-01-23 17:14:36 +01:00
Joaquin Ossa
d5f36c14df Merged PR 4154: update exposures
# Description

Updated exposures with new CheckIn Hero API Invoice report

# Checklist

- [ ] The edited models and dependants run properly with production data.
- [ ] The edited models are sufficiently documented.
- [ ] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

update exposures

Related work items: #26158
2025-01-23 08:50:56 +00:00
Joaquin Ossa
463de78b1e update exposures 2025-01-23 08:50:13 +01:00
Oriol Roqué Paniagua
707950a6db Merged PR 4143: Ensure order in financial aggregations
# Description

Ensure order in financial aggregations by adding a preceding number

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Ensure order

Related work items: #26618
2025-01-22 09:38:18 +00:00
Oriol Roqué Paniagua
49269b8288 Merged PR 4141: Add OSS Sales accounts to the respective Guest Revenue service aggregation
# Description

Adds OSS sales into the respective aggregations, after discussing with Nathan

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Add OSS Sales accounts to the respective Guest Revenue service aggregation

Related work items: #26618
2025-01-21 17:13:46 +00:00
Oriol Roqué Paniagua
437460065e Merged PR 4138: Adds Account Code Name in reporting
# Description

Adds account code name in reporting for sales denom mart in xero

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #26618
2025-01-21 16:37:16 +00:00
Oriol Roqué Paniagua
ddc806583c Merged PR 4130: Propagate aggregations to xero sales reporting
# Description

Propagates the xero aggregations to the reporting model of xero__sales_denom_mart

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #26618
2025-01-21 13:22:36 +00:00
Joaquin Ossa
a99b7f29a7 Merged PR 4126: cih monthly fee to reporting
# Description

CIH monthly fee to reporting

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

cih monthly fee to reporting

Related work items: #26158
2025-01-21 11:40:27 +00:00
Joaquin Ossa
f8cf824c06 cih monthly fee to reporting 2025-01-21 12:37:50 +01:00
Oriol Roqué Paniagua
5394066959 Merged PR 4124: Adds dedicated start date for KPIs
# Description

This is a extremely simple but rather important PR.
It just sets the cutoff for KPIs reporting to April 2022. This affects 1) Main KPIs, 2) Guest KPIs and 3) Account Managers report

Motivation behind this is to have accurate data. Early 2022 might still be shitty, but at least we have a source of truth to compare against (on revenue side, finance P&L)

I set a dedicated variable because currency rates is reading from the same start date, and I intend only to modify KPIs cutoff.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [NA] The edited models are sufficiently documented.
- [NA] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [NA] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged. **I need to manually run a full-refresh on daily listing segmentation that is incremental**

Adds dedicated start date for KPIs

Related work items: #26712
2025-01-21 11:18:16 +00:00
Joaquin Ossa
6141af1eff Merged PR 4076: CIH fees
# Description

Added booking fees for CIH requests and new model of aggregated monthly fee per user

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [x] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #26158
2025-01-21 09:27:21 +00:00
Joaquin Ossa
c02eda9d71 Merged PR 4121: PMS in new dash reporting
# Description

PMS in new dash reporting

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

PMS in new dash reporting

Related work items: #26589
2025-01-21 09:27:08 +00:00
Joaquin Ossa
89f7db1997 back to created date 2025-01-21 10:18:46 +01:00