Commit graph

52 commits

Author SHA1 Message Date
Oriol Roqué Paniagua
335ba9a29b Merged PR 3461: Creates models for listing metrics
# Description

Adds listing metrics model. It's a bit similar as the Deal metrics, but here we can aggregate by deal :)

I'm aware that int_kpis__metric_daily_listings takes quite a bit (3 min). To be optimised later on.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23567
2024-11-07 16:56:43 +00:00
Joaquin Ossa
34ccd894de renamed test entity 2024-11-07 12:56:49 +01:00
Joaquin Ossa
11e1804db0 mtd and weekly agg guest payments 2024-11-07 12:15:52 +01:00
Joaquin Ossa
c89c72aace commit agg_monthly_guest_payments 2024-11-07 12:09:20 +01:00
Joaquin Ossa
50b09c56a1 wip agg 2024-11-07 12:06:37 +01:00
Joaquin Ossa
dba28897d6 wip agg 2024-11-07 12:06:37 +01:00
Joaquin Ossa
cf553cfcb1 monthly and weekly metric models 2024-11-07 12:06:37 +01:00
Oriol Roqué Paniagua
8c23f91242 Merged PR 3451: Adds Deal Daily Lifecycle and metrics
# Description

Changes:
* Creates lifecycle_daily_deal, metric_daily_deals and agg_daily_deals. These follow a different strategy due to the nature of the metrics
* Modifies the dimension macro to ensure deal dimension is included in all models except these ones
* Fixes production issue on currently deployed deal lifecycle and metrics

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23566
2024-11-07 10:49:06 +00:00
Joaquin Ossa
678caa35d7 Removed unnecessary join 2024-11-06 16:27:19 +01:00
Joaquin Ossa
f33bc3a2ca removed new metrics 2024-11-06 16:24:57 +01:00
Joaquin Ossa
b9968c7a72 added new metrics for not cancelled bookings 2024-11-06 12:34:52 +01:00
Joaquin Ossa
f5addc7f4c wip 2024-11-06 12:34:51 +01:00
Joaquin Ossa
9fecfeb91b Merged PR 3439: Weekly aggregated model
# Description

Created new PR to fix schema for test

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23373
2024-11-06 11:11:07 +00:00
Oriol Roqué Paniagua
fd94c19694 Merged PR 3433: Change lifecycle daily to just handle last available day
# Description

Should improve performance of this daily lc model

# Checklist

- [X] The edited models and dependants run properly with production data.
- [ ] The edited models are sufficiently documented.
- [ ] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.
2024-11-06 11:10:31 +00:00
Joaquin Ossa
41a9b55436 saved 2024-11-06 11:48:38 +01:00
Joaquin Ossa
51fabf9efb Changed test 2024-11-06 11:47:47 +01:00
Joaquin Ossa
50b87c9d8f Revert "Merged PR 3430: Weekly aggregated guest journey metrics
# Description

Here I created a weekly aggregated model for guest journey metrics.
I changed the daily_dimension week start and end to iso so it matches the week date obtained by Postgres for this aggregation

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [x] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23373"
2024-11-06 10:25:04 +00:00
Joaquin Ossa
60204b53e8 Merged PR 3430: Weekly aggregated guest journey metrics
# Description

Here I created a weekly aggregated model for guest journey metrics.
I changed the daily_dimension week start and end to iso so it matches the week date obtained by Postgres for this aggregation

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [x] I have checked for DRY opportunities with other models and docs.
- [x] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23373
2024-11-06 10:17:46 +00:00
Joaquin Ossa
4a2c478d8f update schema 2024-11-06 11:11:06 +01:00
Joaquin
079eaac870 Update invoice models 2024-11-06 08:35:30 +01:00
Joaquin
ca510f91a7 update assert_dimension_completeness test 2024-11-06 08:29:02 +01:00
Oriol Roqué Paniagua
f5311fa954 Merged PR 3431: Adds Invoicing metrics
# Description

Same old story: includes all metrics coming from Xero.
Adds a daily model, monthly, mtd + monthly agg and mtd agg
A test to compare values new vs. old
AND fixes the issue I mentioned with the timestamp - an issue in the old KPIs.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23565
2024-11-05 16:57:23 +00:00
Joaquin
7e786649cc Weekly aggregated model 2024-11-05 16:04:41 +01:00
Joaquin
d8a064fd06 commit wip 2024-11-05 15:50:23 +01:00
Joaquin Ossa
4076f016bd Merged PR 3424: aggregated to agg
# Description

Changed names for all aggregated models to agg, updated all references and schemas.
I did a run and test and everything worked correctly

# Checklist

- [x] The edited models and dependants run properly with production data.
- [ ] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

aggregated to agg
2024-11-05 13:46:45 +00:00
Joaquin
c29a47240f Weekly dimension 2024-11-05 13:28:12 +01:00
Joaquin
092e37d58c aggregated to agg 2024-11-05 12:17:26 +01:00
Joaquin
57bc62b21d Merge branch 'models/23372_csat_guest_kpis' of ssh.dev.azure.com:v3/guardhog/Data/data-dwh-dbt-project into models/23372_csat_guest_kpis
Merge issue
2024-11-05 10:36:33 +01:00
Joaquin
2593632411 final changes 2024-11-05 10:29:50 +01:00
Joaquin
eb8e59f8c5 Addressed comments 2024-11-05 10:29:50 +01:00
Joaquin
ee2cb2e40e CSAT score 2024-11-05 10:29:50 +01:00
Joaquin
84b7f2569c final changes 2024-11-05 10:24:17 +01:00
Oriol Roqué Paniagua
b31a6ba194 Merged PR 3419: Adds Host Resolutions metrics in new KPIs
# Description

Adds 2 new metrics:
- xero_host_resolution_amount_paid_in_gbp
- xero_host_resolution_payment_count

Effectively it will split the "real" invoicing sources of revenue from "host resolution payments". This was already reading from 2 different Xero models (bank transactions vs. sales).

We have as usual:
- 1 Daily metric model
- 2 MTD/Monthly metric model
- 2 MTD/Monthly agg model (I already changed the name to agg instead of aggregated)
- 1 test to compare the values match the current setup

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23565
2024-11-05 07:45:41 +00:00
Joaquin
5d642d2c77 Addressed comments 2024-11-04 18:15:13 +01:00
Joaquin
392006b71c CSAT score 2024-11-04 16:51:24 +01:00
Joaquin
d952613fd3 Fixed names 2024-11-04 15:28:31 +01:00
Joaquin
64c3c6d1f0 Addressed comments 2024-11-04 14:29:26 +01:00
Joaquin
21858d4d59 updated test 2024-11-04 11:05:28 +01:00
Joaquin
7d3d11ea7f modified names 2024-11-02 18:32:38 +01:00
Joaquin
19337a9918 save all guest journey check in attributed models 2024-11-02 11:28:22 +01:00
Joaquin
3e5fd5a761 save models wip 2024-11-02 07:02:58 +01:00
Joaquin
201e2c989c Addressed comments 2024-10-31 16:58:58 +01:00
Joaquin
813e710020 Update it to 1 model and added metrics including cancelled bookings 2024-10-31 16:58:40 +01:00
Joaquin
36a1428b23 Created models for new guest kpis 2024-10-31 16:56:29 +01:00
Joaquin
36432024b5 commit new models for guest kpis 2024-10-31 16:51:48 +01:00
Joaquin
6ae900530c save wip of started GJ 2024-10-31 16:51:48 +01:00
Oriol Roqué Paniagua
bf2310301a Merged PR 3391: Adds Check-Out, Cancelled and Billable Bookings
# Description

Adds Check-Out, Cancelled and Billable Bookings in the new KPI flow.

For each of these metrics, it includes:
* Daily model
* Monthly/MTD without dimension aggregates
* Monthly/MTD with dimension aggregates
* Schema entries for the abovementioned 5 models
* Temporary test to compare the different metrics against current production KPIs

I also implemented a quick performance fix that removes the dependency of Billable Bookings from Booking Charge Events, since Bookings table already contains the needed information.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23454
2024-10-31 14:31:19 +00:00
Oriol Roqué Paniagua
3ecbcb2c49 Merged PR 3387: Adds Guest Payments metrics
# Description

Adds Guest Payments metrics, namely:
* deposit_fees_in_gbp
* waiver_payments_in_gbp
* checkin_cover_fees_in_gbp
* total_guest_payments_in_gbp

It includes:
* Daily model
* Monthly/MTD without dimension aggregates
* Monthly/MTD with dimension aggregates
* Schema entries for the abovementioned 5 models
* Temporary test to compare the different metrics against current production KPIs

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23453
2024-10-31 09:03:15 +00:00
Oriol Roqué Paniagua
9585b759a4 Merged PR 3385: Adds Guest Journey with Payment metric
# Description

Adds GJ with Payment. It includes:
* Daily model
* Monthly/MTD without dimension aggregates
* Monthly/MTD with dimension aggregates
* Schema entries for the abovementioned 5 models
* Temporary test to compare against current production KPIs

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #23453
2024-10-30 16:43:50 +00:00
Oriol Roqué Paniagua
22d5b75931 Merged PR 3379: Fixes null on dates
# Description

Fixes dbt test - I forgot to exclude dates when these are null.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [NA] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Fixes null on dates

Related work items: #23453
2024-10-30 13:33:11 +00:00