Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs

# Description

Booking fees is widely used with different meanings, for old dash, for new dash, for both, etc. This is painful. First step to align on a proper naming is ensure that what we report in Main KPIs is clearly stated, which in this case, Booking Fees are now called Old Dashboard Booking Fees.

Changes:
* Modify `stg_seed__accounting_aggregations` seed to rename Booking Fees to Old Dashboard Booking Fees. This is for us to clarify. This is only applied for KPIs compute. I also added an empty space that I mistakenly forgot in the past for `financial_l3_aggregation`.
* Modify KPIs source, i.e., `int_kpis__metric_daily_invoiced_revenue`. Here I forcefully modify the name of the field to `xero_old_dashboard_booking_net_fees_in_gbp`.
* Propagate changes of downstream usages of `xero_booking_net_fees_in_gbp` to `xero_old_dashboard_booking_net_fees_in_gbp`. This affects all models, including the reporting model. On this one we still have both names to avoid breaking it. I will need to modify the data glossary in PBI anyway so I'll do this change as well.
* Modify displayed metric name from Booking Fees Revenue to Old Dashboard Booking Fees Revenue.
* Modify schema so it reflects the proper names, descriptions, and tests.
* Ensure outlier and completion tests still work after this change.

I confirm the field `xero_booking_net_fees_in_gbp` does not exist anymore in the rest of DWH after these changes, except for the abovementioned comment on the reporting line.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #28560

seeds/schema.yml

@@ -208,7 +208,7 @@ seeds:
                 - Other Invoiced Revenue
                 - Verification Fees
                 - Listing Fees
-                - Booking Fees
+                - Old Dashboard Booking Fees
                 - Athena API
                 - E-Deposit API
                 - Guesty Resolutions
@@ -300,7 +300,7 @@ seeds:
                 - 211-Deposit Fees
                 - 131-Verification Fees
                 - 121-Listing Fees
-                - 111-BookingFees
+                - 111-Booking Fees
                 - 141-Athena API
                 - 151-E-Deposit API
                 - 411-Guesty Resolutions

seeds/stg_seed__accounting_aggregations.csv

@@ -4,17 +4,17 @@ account_code,root_aggregation,kpis_aggregation,financial_l1_aggregation,financia
 "202",Deposit Fees,Accounting Guest Revenue,2-Deposit Management,21-Deposit Management Services,211-Deposit Fees
 "203",Verification Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,13-Verification Fees,131-Verification Fees
 "204",Listing Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,12-Listing Fees,121-Listing Fees
-"206",Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-BookingFees
+"206",Old Dashboard Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-Booking Fees
 "207",Listing Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,12-Listing Fees,121-Listing Fees
-"208",Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-BookingFees
+"208",Old Dashboard Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-Booking Fees
 "209",Listing Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,12-Listing Fees,121-Listing Fees
-"210",Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-BookingFees
+"210",Old Dashboard Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-Booking Fees
 "211",Listing Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,12-Listing Fees,121-Listing Fees
-"212",Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-BookingFees
+"212",Old Dashboard Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-Booking Fees
 "213",Listing Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,12-Listing Fees,121-Listing Fees
-"214",Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-BookingFees
+"214",Old Dashboard Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-Booking Fees
 "215",Listing Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,12-Listing Fees,121-Listing Fees
-"216",Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-BookingFees
+"216",Old Dashboard Booking Fees,Invoiced Operator Revenue,1-Guest Screening and Protection,11-Booking Fees,111-Booking Fees
 "217",Deposit Fees,Accounting Guest Revenue,2-Deposit Management,21-Deposit Management Services,211-Deposit Fees
 "218",Damage Waiver Fees,Accounting Guest Revenue,2-Deposit Management,21-Deposit Management Services,210-Damage Waiver Fees
 "219",Athena API,Invoiced API Revenue,1-Guest Screening and Protection,14-Athena API,141-Athena API