counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 3015: Add Kosovo to VAT rates

Browse source 
# Description

This PR adds Kosovo to our guest vat rates seed data. It's an exceptional record because it doesn't comply with the ISO 3166 that the model is supposed to follow. But we need to do it because Kosovo is a recognized country in the Superhog backend.

Nila from finance confirmed that the VAT rate should be 0.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #22148
This commit is contained in:
Pablo Martín 2024-10-02 07:52:21 +00:00
commit d4d15dbed4
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
seeds/schema.yml
View file

@ -50,7 +50,10 @@ seeds:
necessarily mean that the country doesn't have VAT, but rather that we
don't need to charge it to guests from that country.
Country names and codes follow ISO 3166-1. More here: https://en.wikipedia.org/wiki/ISO_3166-1
Country names and codes _almost_ follow ISO 3166-1 (https://en.wikipedia.org/wiki/ISO_3166-1).
The only exception sits in the Kosovo record. Kosovo does not appear as a country in ISO 3166, but is nevertheless
a valid country in the `Country` table of the Superhog backend database. Because of this, we need to include it.
The present codes are made up (not truly ISO 3166 codes) and match the ones present in the backend.
Read more here: https://www.notion.so/knowyourguest-superhog/Guest-Services-Taxes-How-to-calculate-a5ab4c049d61427fafab669dbbffb3a2?pvs=4

1
seeds/stg_seed__guest_services_vat_rates_by_country.csv
View file

@ -119,6 +119,7 @@ Kenya,KE,KEN,404,0.00
Kiribati,KI,KIR,296,0.00
"Korea, Democratic People's Republic of",KP,PRK,408,0.00
"Korea, Republic of",KR,KOR,410,0.00
Kosovo,XK,XKX,383,0.00
Kuwait,KW,KWT,414,0.00
Kyrgyzstan,KG,KGZ,417,0.00
Lao People's Democratic Republic,LA,LAO,418,0.00

1 country_name alpha_2 alpha_3 country_code vat_rate
119 Kiribati KI KIR 296 0.00
120 Korea, Democratic People's Republic of KP PRK 408 0.00
121 Korea, Republic of KR KOR 410 0.00
122 Kosovo XK XKX 383 0.00
123 Kuwait KW KWT 414 0.00
124 Kyrgyzstan KG KGZ 417 0.00
125 Lao People's Democratic Republic LA LAO 418 0.00