From 6f63aae1a1bc2c92ecfca2af622c305723f92483 Mon Sep 17 00:00:00 2001 From: Pablo Martin Date: Tue, 1 Oct 2024 15:49:25 +0200 Subject: [PATCH 1/2] add kosovo --- seeds/stg_seed__guest_services_vat_rates_by_country.csv | 1 + 1 file changed, 1 insertion(+) diff --git a/seeds/stg_seed__guest_services_vat_rates_by_country.csv b/seeds/stg_seed__guest_services_vat_rates_by_country.csv index cdd51e0..ca53225 100644 --- a/seeds/stg_seed__guest_services_vat_rates_by_country.csv +++ b/seeds/stg_seed__guest_services_vat_rates_by_country.csv @@ -119,6 +119,7 @@ Kenya,KE,KEN,404,0.00 Kiribati,KI,KIR,296,0.00 "Korea, Democratic People's Republic of",KP,PRK,408,0.00 "Korea, Republic of",KR,KOR,410,0.00 +Kosovo,XK,XKX,383,0.00 Kuwait,KW,KWT,414,0.00 Kyrgyzstan,KG,KGZ,417,0.00 Lao People's Democratic Republic,LA,LAO,418,0.00 From dcbfcec627c185cc23d09d682450ffd37dd24693 Mon Sep 17 00:00:00 2001 From: Pablo Martin Date: Tue, 1 Oct 2024 15:52:30 +0200 Subject: [PATCH 2/2] add note in docs. --- seeds/schema.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/seeds/schema.yml b/seeds/schema.yml index b0bab44..7207ff8 100644 --- a/seeds/schema.yml +++ b/seeds/schema.yml @@ -50,7 +50,10 @@ seeds: necessarily mean that the country doesn't have VAT, but rather that we don't need to charge it to guests from that country. - Country names and codes follow ISO 3166-1. More here: https://en.wikipedia.org/wiki/ISO_3166-1 + Country names and codes _almost_ follow ISO 3166-1 (https://en.wikipedia.org/wiki/ISO_3166-1). + The only exception sits in the Kosovo record. Kosovo does not appear as a country in ISO 3166, but is nevertheless + a valid country in the `Country` table of the Superhog backend database. Because of this, we need to include it. + The present codes are made up (not truly ISO 3166 codes) and match the ones present in the backend. Read more here: https://www.notion.so/knowyourguest-superhog/Guest-Services-Taxes-How-to-calculate-a5ab4c049d61427fafab669dbbffb3a2?pvs=4