counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 5215: Switch from 20th to 12th for invoicing cap

Browse source 
# Description

After a discussion with Nathan, the invoicing cycle has again been reduced by quite a few days.
We agreed to move the cap from 20th to 12th of the following month.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #30147
This commit is contained in:
Oriol Roqué Paniagua 2025-05-15 14:10:27 +00:00
parent ae9bb524b7
commit baf9d2767c
4 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

6
models/reporting/general/mtd_aggregated_metrics.sql
View file

@ -55,11 +55,11 @@ where
(
(
-- Not show current + previous month if the metric depends on
-- invoicing cycle and it is before the 20th of the month, if it
-- is the 20th of the month or after, only exclude the current
-- invoicing cycle and it is before the 12th of the month, if it
-- is the 12th of the month or after, only exclude the current
-- month.
display_exclusion = 'INVOICING'
and {{ is_date_before_20th_of_previous_month("date") }}
and {{ is_date_before_12th_of_previous_month("date") }}
)
or (
-- Handle exclusion for Churn/MRR metrics: do not show them in the

6
models/reporting/general/mtd_aggregated_metrics_by_deal.sql
View file

@ -47,11 +47,11 @@ where
(
(
-- Not show current + previous month if the metric depends on
-- invoicing cycle and it is before the 20th of the month, if it
-- is the 20th of the month or after, only exclude the current
-- invoicing cycle and it is before the 12th of the month, if it
-- is the 12th of the month or after, only exclude the current
-- month.
m.display_exclusion = 'INVOICING'
and {{ is_date_before_20th_of_previous_month("m.date") }}
and {{ is_date_before_12th_of_previous_month("m.date") }}
)
or (
-- Handle exclusion for Churn/MRR metrics: do not show them in the

6
models/reporting/general/ytd_mtd_aggregated_main_metrics_overview.sql
View file

@ -10,11 +10,11 @@ with
(
(
-- Not show current + previous month if the metric depends on
-- invoicing cycle and it is before the 20th of the month, if it
-- is the 20th of the month or after, only exclude the current
-- invoicing cycle and it is before the 12th of the month, if it
-- is the 12th of the month or after, only exclude the current
-- month.
display_exclusion = 'INVOICING'
and {{ is_date_before_20th_of_previous_month("date") }}
and {{ is_date_before_12th_of_previous_month("date") }}
)
or (
-- Handle exclusion for Churn/MRR metrics: do not show them in the