counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 2887: Check-In Hero - Removing unused fields + schema changes

Browse source 
# Description
This PR closes the ticket #20046

Changes:
* Removes temporary fields marked as legacy in `core__vr_check_in_cover`, after the changes in the 3 PBI Check-In Hero reports.
* Additionally, I modified the schema entry to comply with the current fields available in this model.

# Checklist

- [X] The edited models and dependants run properly with production data. *Checked in local changing the sources to localhost after dropping the fields.*
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs. *N/A*
- [ ] I've picked the right materialization for the affected models. *N/A*

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Remove temporary fields

Related work items: #20046
This commit is contained in:
Oriol Roqué Paniagua 2024-09-18 11:48:49 +00:00
parent 17f7b11a79
commit 985ddb8e4d
2 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
models/reporting/core/core__vr_check_in_cover.sql
View file

@ -34,9 +34,6 @@ select
amount_without_taxes_in_txn_currency as amount_without_taxes_in_txn_currency, amount_without_taxes_in_txn_currency as amount_without_taxes_in_txn_currency,
total_amount_in_gbp as total_amount_in_gbp, total_amount_in_gbp as total_amount_in_gbp,
amount_without_taxes_in_gbp as amount_without_taxes_in_gbp, amount_without_taxes_in_gbp as amount_without_taxes_in_gbp,
total_amount_in_txn_currency as amount_in_txn_currency, -- LEGACY
total_amount_in_gbp as amount_in_gbp, -- LEGACY
checkin_cover_limit_amount_local_curr as checkin_cover_limit_amount_local_curr, checkin_cover_limit_amount_local_curr as checkin_cover_limit_amount_local_curr,
checkin_cover_limit_amount_in_gbp as checkin_cover_limit_amount_in_gbp checkin_cover_limit_amount_in_gbp as checkin_cover_limit_amount_in_gbp
from core__vr_check_in_cover from core__vr_check_in_cover

18
models/reporting/core/schema.yml
View file

@ -323,19 +323,29 @@ models:
description: | description: |
The date at which the guest finished the guest journey. The date at which the guest finished the guest journey.
- name: amount_in_txn_currency - name: total_amount_in_txn_currency
data_type: numeric data_type: numeric
description: | description: |
The amount paid by the guest for the check-in cover, in the currency The amount paid by the guest for the check-in cover, in the currency
in which the payment actually took place. in which the payment actually took place. Tax inclusive.
- name: amount_without_taxes_in_txn_currency
data_type: numeric
description: |
The equivalent amount paid by the guest for the check-in cover, in the currency
in which the payment actually took place, without taxes.
- name: currency - name: currency
data_type: character varying data_type: character varying
description: The currency used by the guest for the payment. description: The currency used by the guest for the payment.
- name: amount_in_gbp - name: total_amount_in_gbp
data_type: numeric data_type: numeric
description: The amount paid by the guest, converted into GBP. description: The amount paid by the guest, converted into GBP. Tax inclusive.
- name: amount_without_taxes_in_gbp
data_type: numeric
description: The equivalent amount paid by the guest, converted into GBP and without taxes.
- name: payment_status - name: payment_status
data_type: character varying data_type: character varying