From 985ddb8e4dec9a66878fab8872ba9d97c603e7fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Wed, 18 Sep 2024 11:48:49 +0000 Subject: [PATCH] Merged PR 2887: Check-In Hero - Removing unused fields + schema changes # Description This PR closes the ticket #20046 Changes: * Removes temporary fields marked as legacy in `core__vr_check_in_cover`, after the changes in the 3 PBI Check-In Hero reports. * Additionally, I modified the schema entry to comply with the current fields available in this model. # Checklist - [X] The edited models and dependants run properly with production data. *Checked in local changing the sources to localhost after dropping the fields.* - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [ ] I have checked for DRY opportunities with other models and docs. *N/A* - [ ] I've picked the right materialization for the affected models. *N/A* # Other - [ ] Check if a full-refresh is required after this PR is merged. Remove temporary fields Related work items: #20046 --- .../reporting/core/core__vr_check_in_cover.sql | 3 --- models/reporting/core/schema.yml | 18 ++++++++++++++---- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/models/reporting/core/core__vr_check_in_cover.sql b/models/reporting/core/core__vr_check_in_cover.sql index 3d01669..d137d9d 100644 --- a/models/reporting/core/core__vr_check_in_cover.sql +++ b/models/reporting/core/core__vr_check_in_cover.sql @@ -34,9 +34,6 @@ select amount_without_taxes_in_txn_currency as amount_without_taxes_in_txn_currency, total_amount_in_gbp as total_amount_in_gbp, amount_without_taxes_in_gbp as amount_without_taxes_in_gbp, - total_amount_in_txn_currency as amount_in_txn_currency, -- LEGACY - total_amount_in_gbp as amount_in_gbp, -- LEGACY - checkin_cover_limit_amount_local_curr as checkin_cover_limit_amount_local_curr, checkin_cover_limit_amount_in_gbp as checkin_cover_limit_amount_in_gbp from core__vr_check_in_cover diff --git a/models/reporting/core/schema.yml b/models/reporting/core/schema.yml index 1b48715..b67e6fa 100644 --- a/models/reporting/core/schema.yml +++ b/models/reporting/core/schema.yml @@ -323,19 +323,29 @@ models: description: | The date at which the guest finished the guest journey. - - name: amount_in_txn_currency + - name: total_amount_in_txn_currency data_type: numeric description: | The amount paid by the guest for the check-in cover, in the currency - in which the payment actually took place. + in which the payment actually took place. Tax inclusive. + + - name: amount_without_taxes_in_txn_currency + data_type: numeric + description: | + The equivalent amount paid by the guest for the check-in cover, in the currency + in which the payment actually took place, without taxes. - name: currency data_type: character varying description: The currency used by the guest for the payment. - - name: amount_in_gbp + - name: total_amount_in_gbp data_type: numeric - description: The amount paid by the guest, converted into GBP. + description: The amount paid by the guest, converted into GBP. Tax inclusive. + + - name: amount_without_taxes_in_gbp + data_type: numeric + description: The equivalent amount paid by the guest, converted into GBP and without taxes. - name: payment_status data_type: character varying