Merged PR 5227: Fix Billable Services New Dash

# Description

Fixes Billable Services categorisation. We were not handling Guest Agreement exclusion. I just changed so instead of including services as billable by default, it's the other way around.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.
This commit is contained in:
Oriol Roqué Paniagua 2025-05-15 15:01:21 +00:00
parent baf9d2767c
commit 53874ab08a

View file

@ -57,12 +57,11 @@ select
end as is_default_service, end as is_default_service,
case case
when when
id_product_service not in ( id_product_service in (
1, -- 'BASIC SCREENING' 2, -- 'SEX OFFENDER CHECK'
5, -- 'BASIC DAMAGE DEPOSIT' 3, -- 'ID VERIFICATION'
6, -- 'DAMAGE DEPOSIT PLUS' 4, -- 'SCREENING PLUS'
7, -- 'BASIC WAIVER' 9 -- 'WAIVER PRO'
8 -- 'WAIVER PLUS'
) )
then true then true
else false else false