From 53874ab08ab5ee8af588e2c6582b22526ece7b74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Thu, 15 May 2025 15:01:21 +0000 Subject: [PATCH] Merged PR 5227: Fix Billable Services New Dash # Description Fixes Billable Services categorisation. We were not handling Guest Agreement exclusion. I just changed so instead of including services as billable by default, it's the other way around. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [ ] I have checked for DRY opportunities with other models and docs. - [ ] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. --- models/staging/core/stg_core__product_service.sql | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/models/staging/core/stg_core__product_service.sql b/models/staging/core/stg_core__product_service.sql index 17384fe..7c8f439 100644 --- a/models/staging/core/stg_core__product_service.sql +++ b/models/staging/core/stg_core__product_service.sql @@ -57,12 +57,11 @@ select end as is_default_service, case when - id_product_service not in ( - 1, -- 'BASIC SCREENING' - 5, -- 'BASIC DAMAGE DEPOSIT' - 6, -- 'DAMAGE DEPOSIT PLUS' - 7, -- 'BASIC WAIVER' - 8 -- 'WAIVER PLUS' + id_product_service in ( + 2, -- 'SEX OFFENDER CHECK' + 3, -- 'ID VERIFICATION' + 4, -- 'SCREENING PLUS' + 9 -- 'WAIVER PRO' ) then true else false