counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 5652: Remove third party and guest involvements tests

Browse source 
# Description

Remove third party and guest involvements tests from Resolutions models, after what we discussed with Ant in the channel #resolutions-data

This fixes the alerts around resolutions.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #31843
This commit is contained in:
Oriol Roqué Paniagua 2025-07-09 12:31:15 +00:00
parent a1b67d20f1
commit 2f14b3305c
2 changed files with 0 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

13
models/reporting/resolutions/schema.yml
View file

@ -403,28 +403,15 @@ models:
data_type: numeric data_type: numeric
description: "Amount of the guest contribution, in case they did, description: "Amount of the guest contribution, in case they did,
in local currency." in local currency."
data_tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
where: not is_incident_missing_details
- name: guest_contribution_currency - name: guest_contribution_currency
data_type: text data_type: text
description: "Currency of the guest contribution." description: "Currency of the guest contribution."
data_tests:
- not_null:
where: "guest_contribution_amount_in_txn_currency > 0 and not is_incident_missing_details"
- name: guest_contribution_amount_in_gbp - name: guest_contribution_amount_in_gbp
data_type: numeric data_type: numeric
description: "Amount of the guest contribution, in case they did, description: "Amount of the guest contribution, in case they did,
in GBP." in GBP."
data_tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
where: not is_incident_missing_details
- name: is_guest_contacted_about_damage - name: is_guest_contacted_about_damage
data_type: boolean data_type: boolean

16
models/staging/resolutions/schema.yml
View file

@ -179,18 +179,10 @@ models:
data_type: numeric data_type: numeric
description: "Amount of the guest contribution, in case they did, description: "Amount of the guest contribution, in case they did,
in local currency." in local currency."
data_tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
where: not is_incident_missing_details
- name: guest_contribution_currency - name: guest_contribution_currency
data_type: text data_type: text
description: "Currency of the guest contribution." description: "Currency of the guest contribution."
data_tests:
- not_null:
where: "guest_contribution_amount_in_txn_currency > 0 and not is_incident_missing_details"
- name: is_guest_contacted_about_damage - name: is_guest_contacted_about_damage
data_type: boolean data_type: boolean
@ -465,19 +457,11 @@ models:
data_type: numeric data_type: numeric
description: "Claim amount in local currency if the host is seeking description: "Claim amount in local currency if the host is seeking
compensation from another platform." compensation from another platform."
data_tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
where: "not is_incident_missing_details"
- name: third_party_claim_currency - name: third_party_claim_currency
data_type: text data_type: text
description: "Currency of the claim amount if the host is seeking description: "Currency of the claim amount if the host is seeking
compensation from another platform." compensation from another platform."
data_tests:
- not_null:
where: "third_party_claim_amount_in_txn_currency > 0 and not is_incident_missing_details"
- name: cosmos_db_timestamp_utc - name: cosmos_db_timestamp_utc
data_type: timestamp data_type: timestamp