From 2f14b3305ca9a4eb80cf86f441c313008c5c41f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Wed, 9 Jul 2025 12:31:15 +0000 Subject: [PATCH] Merged PR 5652: Remove third party and guest involvements tests # Description Remove third party and guest involvements tests from Resolutions models, after what we discussed with Ant in the channel #resolutions-data This fixes the alerts around resolutions. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [ ] I have checked for DRY opportunities with other models and docs. - [ ] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #31843 --- models/reporting/resolutions/schema.yml | 13 ------------- models/staging/resolutions/schema.yml | 16 ---------------- 2 files changed, 29 deletions(-) diff --git a/models/reporting/resolutions/schema.yml b/models/reporting/resolutions/schema.yml index dd310e1..0b8f36d 100644 --- a/models/reporting/resolutions/schema.yml +++ b/models/reporting/resolutions/schema.yml @@ -403,28 +403,15 @@ models: data_type: numeric description: "Amount of the guest contribution, in case they did, in local currency." - data_tests: - - dbt_expectations.expect_column_values_to_be_between: - min_value: 0 - strictly: false - where: not is_incident_missing_details - name: guest_contribution_currency data_type: text description: "Currency of the guest contribution." - data_tests: - - not_null: - where: "guest_contribution_amount_in_txn_currency > 0 and not is_incident_missing_details" - name: guest_contribution_amount_in_gbp data_type: numeric description: "Amount of the guest contribution, in case they did, in GBP." - data_tests: - - dbt_expectations.expect_column_values_to_be_between: - min_value: 0 - strictly: false - where: not is_incident_missing_details - name: is_guest_contacted_about_damage data_type: boolean diff --git a/models/staging/resolutions/schema.yml b/models/staging/resolutions/schema.yml index a648bcf..3a26dda 100644 --- a/models/staging/resolutions/schema.yml +++ b/models/staging/resolutions/schema.yml @@ -179,18 +179,10 @@ models: data_type: numeric description: "Amount of the guest contribution, in case they did, in local currency." - data_tests: - - dbt_expectations.expect_column_values_to_be_between: - min_value: 0 - strictly: false - where: not is_incident_missing_details - name: guest_contribution_currency data_type: text description: "Currency of the guest contribution." - data_tests: - - not_null: - where: "guest_contribution_amount_in_txn_currency > 0 and not is_incident_missing_details" - name: is_guest_contacted_about_damage data_type: boolean @@ -465,19 +457,11 @@ models: data_type: numeric description: "Claim amount in local currency if the host is seeking compensation from another platform." - data_tests: - - dbt_expectations.expect_column_values_to_be_between: - min_value: 0 - strictly: false - where: "not is_incident_missing_details" - name: third_party_claim_currency data_type: text description: "Currency of the claim amount if the host is seeking compensation from another platform." - data_tests: - - not_null: - where: "third_party_claim_amount_in_txn_currency > 0 and not is_incident_missing_details" - name: cosmos_db_timestamp_utc data_type: timestamp