diff --git a/code_thingies/dbtlearn/macros/positive_value.sql b/code_thingies/dbtlearn/macros/positive_value.sql new file mode 100644 index 0000000..148a7bc --- /dev/null +++ b/code_thingies/dbtlearn/macros/positive_value.sql @@ -0,0 +1,8 @@ +{% test positive_value(model, column_name) %} +SELECT + * +FROM + {{ model }} +WHERE + {{ column_name }} < 1 +{% endtest %} \ No newline at end of file diff --git a/code_thingies/dbtlearn/models/dim/dim_listings_cleansed.sql b/code_thingies/dbtlearn/models/dim/dim_listings_cleansed.sql index c3371aa..de68ced 100644 --- a/code_thingies/dbtlearn/models/dim/dim_listings_cleansed.sql +++ b/code_thingies/dbtlearn/models/dim/dim_listings_cleansed.sql @@ -16,7 +16,7 @@ SELECT CASE WHEN minimum_nights = 0 THEN 1 ELSE minimum_nights - END AS mininum_nights, + END AS minimum_nights, host_id, REPLACE(price_str,'$','')::money AS price, created_at, diff --git a/code_thingies/dbtlearn/models/dim/dim_listings_with_hosts.sql b/code_thingies/dbtlearn/models/dim/dim_listings_with_hosts.sql index ee05cc2..6ccf1f0 100644 --- a/code_thingies/dbtlearn/models/dim/dim_listings_with_hosts.sql +++ b/code_thingies/dbtlearn/models/dim/dim_listings_with_hosts.sql @@ -13,7 +13,7 @@ SELECT listings.listing_id, listings.listing_name, listings.room_type, - listings.mininum_nights, + listings.minimum_nights, listings.price, listings.host_id, hosts.host_name, diff --git a/code_thingies/dbtlearn/models/schema.yml b/code_thingies/dbtlearn/models/schema.yml index b1f9258..cefd2d4 100644 --- a/code_thingies/dbtlearn/models/schema.yml +++ b/code_thingies/dbtlearn/models/schema.yml @@ -25,3 +25,7 @@ models: 'Hotel room' ] + - name: minimum_nights + tests: + - positive_value + diff --git a/code_thingies/dbtlearn/tests/dim_listings_minimum_nights.sql b/code_thingies/dbtlearn/tests/dim_listings_minimum_nights.sql deleted file mode 100644 index 8dfaa20..0000000 --- a/code_thingies/dbtlearn/tests/dim_listings_minimum_nights.sql +++ /dev/null @@ -1,5 +0,0 @@ -SELECT * -FROM - {{ ref('dim_listings_cleansed') }} -WHERE - mininum_nights < 1