From 51fe6cae99aa3ba060c99bfdd9c604660ae288b7 Mon Sep 17 00:00:00 2001 From: counterweight Date: Sat, 5 Apr 2025 14:05:15 +0200 Subject: [PATCH] tidy up checkboxes --- src/front/components/TrustCheckboxes.js | 9 +-------- src/front/pages/offers.js | 18 ++++++++---------- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/src/front/components/TrustCheckboxes.js b/src/front/components/TrustCheckboxes.js index bd47e84..f1b8768 100644 --- a/src/front/components/TrustCheckboxes.js +++ b/src/front/components/TrustCheckboxes.js @@ -12,7 +12,6 @@ class TrustCheckboxes { render() { const checkboxesDetails = [ { - id: 'my-trusted', label: 'Mis confiados', containerProperty: 'myTrustedContainer', checkboxProperty: 'myTrustedCheckboxElement', @@ -20,7 +19,6 @@ class TrustCheckboxes { isDisabled: true, }, { - id: 'my-trusted-trusted', label: 'Los confiados de mis confiados', containerProperty: 'myTrustedTrustedContainer', checkboxProperty: 'myTrustedTrustedCheckboxElement', @@ -28,7 +26,6 @@ class TrustCheckboxes { isDisabled: false, }, { - id: 'all-members', label: 'Todos los miembros', containerProperty: 'allMembersContainer', checkboxProperty: 'allMembersCheckboxElement', @@ -39,7 +36,6 @@ class TrustCheckboxes { for (const checkboxDetails of checkboxesDetails) { this[checkboxDetails.containerProperty] = this.buildCheckbox({ - id: checkboxDetails.id, label: checkboxDetails.label, }); @@ -61,15 +57,12 @@ class TrustCheckboxes { } } - buildCheckbox({ id, label }) { + buildCheckbox({ label }) { const checkboxContainer = document.createElement('div'); checkboxContainer.className = 'checkbox-row'; - checkboxContainer.id = `${id}-checkbox-area`; const checkbox = document.createElement('input'); checkbox.type = 'checkbox'; - checkbox.name = id; - checkbox.id = `${id}-checkbox`; checkbox.checked = true; const labelElement = document.createElement('label'); diff --git a/src/front/pages/offers.js b/src/front/pages/offers.js index c31f6f1..53e18e2 100644 --- a/src/front/pages/offers.js +++ b/src/front/pages/offers.js @@ -142,19 +142,23 @@ class CreateOfferModal { this.btcMethodCheckboxes.render(); - //Continue moving components up here - const trustDiv = document.createElement('div'); - trustDiv.id = 'trust-area'; trustDiv.className = 'create-offer-step'; const trustHeading = document.createElement('h3'); trustHeading.textContent = '¿Quién puede ver la oferta?'; trustDiv.appendChild(trustHeading); const trustContentDiv = document.createElement('div'); - trustContentDiv.id = 'trusted-checkboxes-area'; trustDiv.appendChild(trustContentDiv); controls.appendChild(trustDiv); + this.trustCheckboxes = new TrustCheckboxes({ + parentElement: trustContentDiv, + }); + + this.trustCheckboxes.render(); + + //Continue moving components up here + const otherDiv = document.createElement('div'); otherDiv.id = 'other-area'; otherDiv.className = 'create-offer-step'; @@ -191,12 +195,6 @@ class CreateOfferModal { this.parentElement.appendChild(this.element); - this.trustCheckboxes = new TrustCheckboxes({ - parentElement: document.getElementById('trusted-checkboxes-area'), - }); - - this.trustCheckboxes.render(); - this.bigNotesCheckbox = new BigNotesCheckbox({ parentElement: document.getElementById('other-area'), });