counterweight/lolafect
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Made S3 client injectable to ease mocking for testing

Browse source
This commit is contained in:
Pablo Martin 2022-12-30 15:47:13 +01:00
parent f1ed3832e5
commit f684b2a043
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
lolafect/lolaconfig.py
View file

@ -62,17 +62,21 @@ class LolaConfig:
DEFAULT_KUBERNETES_IMAGE if kubernetes_image is None else kubernetes_image DEFAULT_KUBERNETES_IMAGE if kubernetes_image is None else kubernetes_image
) )
def fetch_slack_webhooks(self) -> None: def fetch_slack_webhooks(self, s3_client=None) -> None:
""" """
Read the slack webhooks file from S3 and store the webhooks in memory. Read the slack webhooks file from S3 and store the webhooks in memory.
:param s3_client: a client to fetch files from S3.
:return: None :return: None
""" """
if s3_client is None:
s3_client = boto3.client("s3")
self.SLACK_WEBHOOKS = json.loads( self.SLACK_WEBHOOKS = json.loads(
boto3.client("s3") s3_client.get_object(
.get_object(Bucket=self.S3_BUCKET_NAME, Key=self.SLACK_WEBHOOKS_FILE)[ Bucket=self.S3_BUCKET_NAME, Key=self.SLACK_WEBHOOKS_FILE
"Body" )["Body"]
]
.read() .read()
.decode("utf-8") .decode("utf-8")
) )