counterweight/lolafect
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove hardcoding

Browse source
This commit is contained in:
Pablo Martin 2023-02-02 16:42:05 +01:00
parent a7b1f55ff1
commit df3d9f0c7e
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lolafect/data_testing.py
View file

@ -23,7 +23,7 @@ def run_data_test_on_mysql(
""" """
Validate a query and an expectation suite against a given MySQL server. Validate a query and an expectation suite against a given MySQL server.
:param name: a name for the data test. :param name: a unique name for the data test.
:param mysql_credentials: credentials for the MySQL instance. :param mysql_credentials: credentials for the MySQL instance.
:param query: the query to test against. :param query: the query to test against.
:param expectations: the expectations on the dataset. :param expectations: the expectations on the dataset.
@ -60,7 +60,7 @@ def create_in_memory_data_context(
data_context = BaseDataContext( data_context = BaseDataContext(
project_config=DataContextConfig( project_config=DataContextConfig(
datasources={ datasources={
"HARCODED": DatasourceConfig( # f"{mysql_credentials['host']}:{mysql_credentials['port']}": DatasourceConfig( f"{mysql_credentials['host']}:{mysql_credentials['port']}": DatasourceConfig(
class_name="Datasource", class_name="Datasource",
execution_engine={ execution_engine={
"class_name": "SqlAlchemyExecutionEngine", "class_name": "SqlAlchemyExecutionEngine",
@ -131,7 +131,7 @@ def create_checkpoint(
"validations": [ "validations": [
{ {
"batch_request": { "batch_request": {
"datasource_name": "HARCODED", "datasource_name": f"{mysql_credentials['host']}:{mysql_credentials['port']}",
"data_connector_name": "default_runtime_data_connector_name", "data_connector_name": "default_runtime_data_connector_name",
"data_asset_name": f"{expectation_suite_name}_validation_query", "data_asset_name": f"{expectation_suite_name}_validation_query",
"runtime_parameters": {"query": query_for_checkpoint}, "runtime_parameters": {"query": query_for_checkpoint},