stuff

scratch/20260320.md

@@ -0,0 +1,28 @@
+
+# 2026-03-20 Fulgur / Volcano meeting
+
+Meeting with:
+- Alexandre
+- Oleg N. 
+- Denis
+- Carlos Minero
+
+
+
+- Next week (Friday) Impact iTech report deadline (27th March)
+- Alexandre confirmed they got some "early feedback" but, decided not to share more
+- Alexandre proceeds to show a Figma prototype (after asking Oleg N. for permission)
+  - "We all understand we won't be using Telegram, so we need something more self-serving"
+  - "Idea is to only work on Fixed Rate Loans and Lines of Credit"
+  - "Months designed to be 3-6-12 months"
+  - "Figma shows non-binding info"
+  - NB: you don't need to ask the loan purpose in the first stage.
+  - NB: do you have an account by the time? Conversation around whether proposals sign befor or after KYC. Apparently consensus is after KYC. But there is the fine print that "someone" is a customer only after they signed ONE customer.
+  - We discussed about the different options on Komainu vs Bank showing custody 
+- Alexandre asks for this question to be held weekly.
+- Oleg N. mentioned they forked Lana to extend it when they need for their own development efforts.
+
+
+- Surprised that Alexandre is running Ubuntu
+ 
+- 

scratch/coderabbit.md

@@ -0,0 +1,78 @@
+# Coderabbit exploration
+
+2026-03-19, I'm exploring around coderabbit.
+
+## Auth
+
+Our auth is tied by github.
+
+## The funky user
+
+I checked the user lists and there's this guy that goes by `ayushsaksena30` who appears in our user list. He's not part of our Github org and he somehow got a seat assigned. From what I understand after looking at the Subscription and Billing section, we get charged 30$ per assigned user.
+
+I'm concerned security wise (who's this guy? how did he get in here? what power does he has as a member level user?), plus we shouldn't go around paying for seats stupidly.
+
+I checked and he has one open PR in lana-bank: https://github.com/GaloyMoney/lana-bank/pull/4276
+
+Does this mean anybody who opens a PR in lana-bank will get a seat automatically? Are we fine with that?
+
+Okay, it seems this is the setting I should fiddle with: https://docs.coderabbit.ai/management/seat-assignment#manual-approval
+
+
+## Local plugin
+
+Coderabbit has plugins for Claude Code, Codex, etc.
+
+You can install this locally, auth, and then call it with a simple command. Performs the same type of review as what we see in github. If we truly value the coderabbit suggestions, then it would be useful to run this locally before just throwing an unreviewed PR, thus making the PR review just an automated check/guardrail.
+
+More details here: https://docs.coderabbit.ai/cli/claude-code-integration
+
+
+## PR Summaries
+
+Documented here: https://docs.coderabbit.ai/pr-reviews/summaries
+Can be configured here: https://app.coderabbit.ai/organization/settings/review/summary
+
+- They can be turned on or off
+- Prompt can be modified
+
+
+## PR Review
+
+Most interesting details can be modified here: https://app.coderabbit.ai/organization/settings/review/behavior
+
+Mostly, adapt prompts for certain codepaths, and make filters around paths and PR tags.
+
+## Pre-merge checks
+
+Mostly feel arbitrary stuff (Docstring coverage?), I think it's going to be more noise than help.
+
+The only one which could be interesting is the "Assess how well the PR addresses linked issues.", but we would need to see how well it reasons out, plus think about what happens with issue-less PRs or PRs with anemic issues.
+
+The custom checks is more interesting. It feels like a good idea for conventions that are philosophical and easy to catch through observation, but hard to nail down in specific CI scripts for checking.
+
+One check, for example, could be that the PR updates relevant parts of the documentation alongside it.
+
+
+## Coderabbit config
+
+We can configure via file, we definetely should go for that if we stick with the tool: https://docs.coderabbit.ai/getting-started/yaml-configuration
+
+## Learnings 
+
+Kind of a long-term memory tool. How good will depend on what it picks up. Hard to maintain if it's only manageable through web UI, will probably need curation. Exportable via CSV, but still feels quite walled-garden-ish.
+
+It's also unclear what's the diff point between learning and code guidelines.
+
+https://app.coderabbit.ai/learnings
+
+
+## Other stuff
+
+Parts of their own docs feel like slop, which I don't like. 
+
+For example, the sections around this link: https://docs.coderabbit.ai/knowledge-base/learnings#kpi-cards, read like slop. Purely descriptive, boring and systematic, no value in them.
+
+
+I would basically look into this instead: https://code.claude.com/docs/en/github-actions
+