data-dwh-dbt-project/macros
Oriol Roqué Paniagua b61fe3f70d Merged PR 2522: Don't Repeat Yourself for KPIs - Applied to Bookings
# Description

What's new:
- Creation of `get_kpi_dimensions`: new macro to have a single point of source of configuration for dimensions for the KPIs. It's a way to enforce global variables on-demand. I kind of like this approach and we could do it for Xero models as well :)
- Modification of `int_core__mtd_booking_metrics` and `int_dates_mtd_by_dimension`: removal of duplicated code within the dimension context. Uses Jinja code and applies different configurations depending on the dimension chosen. Still, different metrics are placed in different CTEs. I believe it might be possible to also configure metrics BUT at the cost of over-complexifying the macro logic, so I wouldn't go for it at this stage.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] **I have checked for DRY opportunities with other models and docs.**
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #19325
2024-08-08 13:19:57 +00:00
..
tests add length between test 2024-06-20 15:13:21 +02:00
.gitkeep start project 2024-01-18 11:24:35 +01:00
calculate_safe_relative_increment.sql Merged PR 2232: KPI refactor - 1st step, bookings 2024-07-08 15:58:36 +00:00
generate_schema_name.sql macros docs 2024-05-22 11:42:42 +02:00
generate_stripe_sources_unioned_select.sql Create macro and use it in balance transactions 2024-03-05 13:33:13 +01:00
get_kpi_dimensions.sql Merged PR 2522: Don't Repeat Yourself for KPIs - Applied to Bookings 2024-08-08 13:19:57 +00:00
is_date_before_previous_month.sql Merged PR 2257: Expose guest revenue and guest journey payment metrics 2024-07-10 14:17:05 +00:00