fa6114b2af
# Description As raised by Kayla, Retained metrics are not computed correctly in AM Account Margin report, see screenshot:  Issue lies in the fact that Guest Payments contains more dimensions than the rest of the models. This is generating duplicates in the combination_of_sources CTE, but these are effectively hidden because of the sum() applied of the metrics. In the case of a Deal having in the same day Guest Payments with different dimensions from those selected, AND on the same day having a value on Invoiced Revenue or Host Resolutions, then the Invoiced Revenue or Host Resolutions would be duplicated. This PR aims to fix this issue, and also adds a few tests on the base model for AM Account Margin to ensure this is kind of error raises an alert. I'll be debugging other affected models and increase the robustness test-wise; as well as gathering the full impact. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [ ] I have checked for DRY opportunities with other models and docs. - [ ] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #29227 |
||
|---|---|---|
| .. | ||
| athena | ||
| check_in_hero | ||
| core | ||
| cross | ||
| edeposit | ||
| hubspot | ||
| kpis | ||
| resolutions | ||
| screen_and_protect | ||
| xero | ||
