8a639413f1
Refactor mtd joins to improve performance, as stated in the ticket:
We noticed that some of the new models for MTD purposes (KPIs reporting) take quite a bit of time to run some simple joins.
The main reason is that there's a double join that can be simplified. The current state is:
```
from int_dates_mtd d
inner join
sometable t
on extract(year from t.table_date) = d.year
and extract(month from t.table_date) = d.month
and extract(day from t.table_date) <= d.day
```
and it can be changed to:
```
from int_dates_mtd d
inner join
sometable t
on date_trunc('month', t.table_date)::date = d.first_day_month
and extract(day from t.table_date) <= d.day
```
which is way faster, and keeps the same computation
Related work items: #18330
77 lines
2.9 KiB
SQL
77 lines
2.9 KiB
SQL
/*
|
|
This model provides Month-To-Date (MTD) based on Guest Revenue metrics.
|
|
|
|
*/
|
|
{% set revenue_verification_payment_type_items = "('FEE','WAIVER','CHECKINCOVER')" %}
|
|
{% set relevant_document_statuses = "('PAID', 'AUTHORISED')" %}
|
|
{% set waiver_items = "('DAMAGE WAVER','DAMAGE WAIVER')" %}
|
|
|
|
{{ config(materialized="table", unique_key="date") }}
|
|
with
|
|
int_core__verification_payments as (
|
|
select * from {{ ref("int_core__verification_payments") }}
|
|
),
|
|
int_xero__credit_note_line_items as (
|
|
select * from {{ ref("int_xero__credit_note_line_items") }}
|
|
),
|
|
int_xero__credit_notes as (select * from {{ ref("int_xero__credit_notes") }}),
|
|
int_dates_mtd as (select * from {{ ref("int_dates_mtd") }}),
|
|
|
|
-- Paid Guest Revenue MTD --
|
|
guest_payments_year_month as (
|
|
select
|
|
d.date,
|
|
sum(vp.amount_in_gbp) as total_guest_payments_in_gbp,
|
|
sum(
|
|
case
|
|
when
|
|
upper(vp.verification_payment_type)
|
|
in {{ revenue_verification_payment_type_items }}
|
|
then vp.amount_in_gbp
|
|
else null
|
|
end
|
|
) as total_guest_income_in_gbp
|
|
from int_dates_mtd d
|
|
inner join
|
|
int_core__verification_payments vp
|
|
on date_trunc('month', vp.payment_paid_date_utc)::date = d.first_day_month
|
|
and extract(day from vp.payment_paid_date_utc) <= d.day
|
|
where upper(vp.payment_status) = {{ var("paid_payment_state") }}
|
|
group by 1
|
|
),
|
|
-- Waiver Credit Notes MTD --
|
|
-- We need to get the credited waivers for those
|
|
-- host-takes-waiver cases
|
|
waiver_credit_notes as (
|
|
select d.date, sum(cnli.line_amount_wo_taxes_in_gbp) as waiver_fees_credited
|
|
from int_dates_mtd d
|
|
inner join
|
|
int_xero__credit_notes cn
|
|
on date_trunc('month', cn.credit_note_issued_date_utc)::date = d.first_day_month
|
|
and extract(day from cn.credit_note_issued_date_utc) <= d.day
|
|
inner join
|
|
int_xero__credit_note_line_items cnli
|
|
on cn.id_credit_note = cnli.id_credit_note
|
|
where
|
|
upper(cn.credit_note_status) in {{ relevant_document_statuses }}
|
|
and upper(cnli.item_code) in {{ waiver_items }}
|
|
group by 1
|
|
)
|
|
-- Final aggregation of subqueries --
|
|
select
|
|
d.year,
|
|
d.month,
|
|
d.day,
|
|
d.date,
|
|
d.is_end_of_month,
|
|
d.is_current_month,
|
|
nullif(gpym.total_guest_payments_in_gbp, 0) as total_guest_payments_in_gbp,
|
|
-- Deduct from total guest income the host-takes-waiver income
|
|
nullif(
|
|
coalesce(gpym.total_guest_income_in_gbp, 0)
|
|
- coalesce(wcn.waiver_fees_credited, 0),
|
|
0
|
|
) as total_guest_revenue_in_gbp
|
|
from int_dates_mtd d
|
|
left join guest_payments_year_month gpym on gpym.date = d.date
|
|
left join waiver_credit_notes wcn on wcn.date = d.date
|