5928a198b6
# Description This fixes the duplication error when the same deal has more than one contact. Impact was not massive, it just affected because of the Home to Host account and this has happened during the past week. There were other cases that contained duplicates but these were not invoiced so it didn't affect the total sum. Changes: * Contacts now has a boolean field indicating if a deal exists. * Contacts now has a boolean field indicating if that contact has a deal informed and it's the last updated one. This is opinionated - it could have been done with creation, for instance. * Sales monthly trends forces the last updated contact to be true. * Improved robustness by adding tests. Note that modifying the logic in intermediate on `int_xero__sales_monthly_trends` by changing `id_deal` per `id_contact` would not have worked - we need to do this compute by deal to ensure that any invoicing is reported MoM and YTD. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #28576 |
||
|---|---|---|
| .. | ||
| schema.yml | ||
| xero__bank_transaction_denom_mart.sql | ||
| xero__bank_transaction_line_items.sql | ||
| xero__bank_transactions.sql | ||
| xero__contacts.sql | ||
| xero__credit_note_line_items.sql | ||
| xero__credit_notes.sql | ||
| xero__invoice_line_items.sql | ||
| xero__invoices.sql | ||
| xero__net_fees.sql | ||
| xero__net_fees_by_deal.sql | ||
| xero__sales_denom_mart.sql | ||
| xero__sales_monthly_trends.sql | ||