data-dwh-dbt-project/models/intermediate
Oriol Roqué Paniagua be0b8c41b6 Merged PR 4411: Propagates New Dash/Old Dash/APIs split in KPIs as per Business Scope
# Description

Changes:
* Adapt business_kpis_configuration to include By Business Scope as production dimension.
* Sets in int_mtd_metrics_vs_previous_year the selection of business scope dimension for all KPIs models. This does not affect cross kpis models (churn/mrr). I might need to check later how to adapt Churn to include this dimension, but it's not considered as for this PR. Lastly, Billable Bookings excludes New Dash.
* Adapts condition in int_mtd_metrics_vs_previous_year so MTD values would appear independently of these appearing in the previous year. This is, the model was considering that to show current month MTD values, the dimension needed to exist the year prior. This does not happen with New Dash and I assume we never noticed because in any case, most of our dimensions have quite a long history.
* Adapts int_kpis__agg_dates_main_kpis to include the business scope dimension. By the way it's actually handled, it kind of assumes that a Deal can only be in New or Old Dash (this is correct), but while on New Dash, this deal won't have data for Old Dash (this might not be 100% correct). In any case, the global figure should be ok, and only on the deal + business scope dimensionality this could cause some potential problems. However, this is not being reported anyway at the moment.
* Adapts int_kpis__agg_dates_main_kpis to have a proper variable value for the dimensions, and this is further included in business_kpis_configuration as any other model.

Small changes:
* Adapts Churn metrics to read from dimension_deals rather than core__deals. This should be more accurate anyway.

# Checklist

- [ ] The edited models and dependants run properly with production data.
- [ ] The edited models are sufficiently documented.
- [ ] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Propagates New Dash/Old Dash/APIs split in KPIs as per Business Scope

Related work items: #27356
2025-02-14 14:12:39 +00:00
..
athena Merged PR 4106: Avoids duplicates in athena verification with fees after price changes 2025-01-19 10:07:39 +00:00
check_in_hero back to created date 2025-01-21 10:18:46 +01:00
core Fixed variable call and naming 2025-02-14 12:19:15 +01:00
cross Merged PR 4411: Propagates New Dash/Old Dash/APIs split in KPIs as per Business Scope 2025-02-14 14:12:39 +00:00
edeposit change "tests:" to "data_tests:" 2025-01-13 16:00:35 +01:00
hubspot change "tests:" to "data_tests:" 2025-01-13 16:00:35 +01:00
kpis Merged PR 4411: Propagates New Dash/Old Dash/APIs split in KPIs as per Business Scope 2025-02-14 14:12:39 +00:00
screen_and_protect Addressed comments 2025-02-13 15:31:22 +01:00
xero Merged PR 4228: First version of sales - monthly trends 2025-01-31 08:33:15 +00:00