a3038089e8
# Description Fixes the Account Growth issue on the rank/share on revenue metrics. Issue was that the share needs to be shifted one month for account computation; meaning that the impact score of April relies on the share from March (as there's no April revenue data). The shift also affected the rank as it's based on the share. Solution is: * Re-bring actual revenue share and attribute it to the correct month * Apply a coalesce giving priority to the revenue share/rank from the correct month. If no data is available (ongoing month), show share/rank of previous month. This is intended to help quantify account importance in the ongoing month - as it's actually the case in the report Tested locally + run in prod to check the report performance. Small note, this makes revenue share not adding up anymore to 100% as accounts that go live in the same month are excluded. This is exactly the same as for Billable Items. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [ ] I have checked for DRY opportunities with other models and docs. - [ ] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #30013 |
||
|---|---|---|
| .. | ||
| athena | ||
| check_in_hero | ||
| core | ||
| cross | ||
| edeposit | ||
| hubspot | ||
| kpis | ||
| resolutions | ||
| screen_and_protect | ||
| xero | ||