# Description Takes into account @<Pablo Martín> 's feedback from the previous PR, slightly modified. This PR separates 1) the dimensions while developing vs. 2) the dimensions once these are available for production. This are within the same file of macro configuration for KPIs, namely `business_kpis_configuration`. End-goal, all CTEs in `int_mtd_vs_previous_year_metrics` will read from this new macro `get_kpi_dimensions_for_production`, so eventually we won't need any hardcode once we want to add new dimensions. In the meantime, I'll be adding this new line for each PR (still 2 missing :D) # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [ ] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [ ] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #19325 |
||
|---|---|---|
| .. | ||
| int_daily_currency_exchange_rates.sql | ||
| int_dates.sql | ||
| int_dates_by_deal.sql | ||
| int_dates_mtd.sql | ||
| int_dates_mtd_by_dimension.sql | ||
| int_monthly_aggregated_metrics_history_by_deal.sql | ||
| int_mtd_aggregated_metrics.sql | ||
| int_mtd_vs_previous_year_metrics.sql | ||
| int_simple_exchange_rates.sql | ||
| schema.yml | ||