8ddb695947
# Description Adds GJ Created, Started and Completed. Each model has: * A Daily model * A Monthly/MTD without dimension aggregate * A Monthly/MTD with dimension aggregate * A comparison vs. the current flow of KPIs in the form of a test It's quite similar as for Created Bookings. The main difference is that 1) reads from Verification Requests table and 2) I don't compute a New Dash dimension. This helps actually validating the logic of the dimension configuration macro, which works good. I confirm that the 3 tests of comparison vs. current data work well in my local - i.e. identical content for Global, Billing Country for these 3 metrics since 2022. This does not include: * Guest Journeys with Payment. I'll do this in a separated PR * Guest Payments/Revenue. I'll do this in a separated PR # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [NA] I have checked for DRY opportunities with other models and docs. **Briefly discussed with Pablo, we'll leave it like this for the time being** - [X] I've picked the right materialization for the affected models. **Runs quite fast** # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #23453 |
||
|---|---|---|
| .. | ||
| .gitkeep | ||
| kpis_additive_metrics_per_dimension_are_consistent.sql | ||
| kpis_global_metrics_outlier_detection.sql | ||
| tmp_kpis_refactor_equivalent_completed_guest_journeys.sql | ||
| tmp_kpis_refactor_equivalent_created_bookings.sql | ||
| tmp_kpis_refactor_equivalent_created_guest_journeys.sql | ||
| tmp_kpis_refactor_equivalent_started_guest_journeys.sql | ||