86719b6a10
# Description This PR originally started with the intent of modifying the applicable logic for waivers where the host takes the risk (in order to follow the [current state of this specification](https://www.notion.so/knowyourguest-superhog/Guest-Services-Taxes-How-to-calculate-a5ab4c049d61427fafab669dbbffb3a2?pvs=4)). The verification payments model was quite convoluted already: adding this logic was turning it into an unmanageable ball of hair. So I broke the rules and refactored in the same PR. The end result is that: - The model implementation has changed quite a bit. - Behavior for everything but host-takes-risk waivers should remain unchanged. - Behaviour for host-takes-risk waivers should have changed. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #20043 |
||
|---|---|---|
| .. | ||
| athena | ||
| core | ||
| cross | ||
| edeposit | ||
| hubspot | ||
| kpis | ||
| xero | ||