counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
data-dwh-dbt-project/models/intermediate/kpis
History
Oriol Roqué Paniagua f799a8d30f Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 
# Description

Booking fees is widely used with different meanings, for old dash, for new dash, for both, etc. This is painful. First step to align on a proper naming is ensure that what we report in Main KPIs is clearly stated, which in this case, Booking Fees are now called Old Dashboard Booking Fees.

Changes:
* Modify `stg_seed__accounting_aggregations` seed to rename Booking Fees to Old Dashboard Booking Fees. This is for us to clarify. This is only applied for KPIs compute. I also added an empty space that I mistakenly forgot in the past for `financial_l3_aggregation`.
* Modify KPIs source, i.e., `int_kpis__metric_daily_invoiced_revenue`. Here I forcefully modify the name of the field to `xero_old_dashboard_booking_net_fees_in_gbp`.
* Propagate changes of downstream usages of `xero_booking_net_fees_in_gbp` to `xero_old_dashboard_booking_net_fees_in_gbp`. This affects all models, including the reporting model. On this one we still have both names to avoid breaking it. I will need to modify the data glossary in PBI anyway so I'll do this change as well.
* Modify displayed metric name from Booking Fees Revenue to Old Dashboard Booking Fees Revenue.
* Modify schema so it reflects the proper names, descriptions, and tests.
* Ensure outlier and completion tests still work after this change.

I confirm the field `xero_booking_net_fees_in_gbp` does not exist anymore in the rest of DWH after these changes, except for the abovementioned comment on the reporting line.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #28560
2025-03-18 14:55:32 +00:00
..
projected Merged PR 4665: Projected Bookings to the end of the current month 2025-03-11 14:34:30 +00:00
_kpis_readme.md
int_kpis__agg_daily_created_bookings.sql Merged PR 4665: Projected Bookings to the end of the current month 2025-03-11 14:34:30 +00:00
int_kpis__agg_daily_deals.sql Merged PR 4395: Propagates business scope into Deal/Listing metrics 2025-02-13 16:34:14 +00:00
int_kpis__agg_daily_listings.sql
int_kpis__agg_daily_new_dash_chargeable_services.sql
int_kpis__agg_daily_new_dash_created_services.sql
int_kpis__agg_dates_main_kpis.sql Merged PR 4411: Propagates New Dash/Old Dash/APIs split in KPIs as per Business Scope 2025-02-14 14:12:39 +00:00
int_kpis__agg_monthly_billable_bookings.sql
int_kpis__agg_monthly_check_out_bookings.sql Merged PR 4425: Reworks Billable Bookings metrics 2025-02-17 15:59:21 +00:00
int_kpis__agg_monthly_completed_guest_journeys.sql
int_kpis__agg_monthly_created_bookings.sql Merged PR 4304: Adds Cancelled and Not Cancelled Created Bookings 2025-02-06 13:13:02 +00:00
int_kpis__agg_monthly_created_guest_journeys.sql
int_kpis__agg_monthly_guest_journeys_with_payment.sql
int_kpis__agg_monthly_guest_payments.sql
int_kpis__agg_monthly_host_resolutions.sql
int_kpis__agg_monthly_invoiced_revenue.sql Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 2025-03-18 14:55:32 +00:00
int_kpis__agg_monthly_new_dash_chargeable_services.sql
int_kpis__agg_monthly_new_dash_created_services.sql
int_kpis__agg_monthly_started_guest_journeys.sql
int_kpis__agg_mtd_billable_bookings.sql
int_kpis__agg_mtd_check_out_bookings.sql Merged PR 4425: Reworks Billable Bookings metrics 2025-02-17 15:59:21 +00:00
int_kpis__agg_mtd_completed_guest_journeys.sql
int_kpis__agg_mtd_created_bookings.sql Merged PR 4304: Adds Cancelled and Not Cancelled Created Bookings 2025-02-06 13:13:02 +00:00
int_kpis__agg_mtd_created_guest_journeys.sql
int_kpis__agg_mtd_guest_journeys_with_payment.sql
int_kpis__agg_mtd_guest_payments.sql
int_kpis__agg_mtd_host_resolutions.sql
int_kpis__agg_mtd_invoiced_revenue.sql Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 2025-03-18 14:55:32 +00:00
int_kpis__agg_mtd_started_guest_journeys.sql
int_kpis__agg_weekly_new_dash_chargeable_services.sql
int_kpis__agg_weekly_new_dash_created_services.sql
int_kpis__dimension_daily_accommodation.sql
int_kpis__dimension_date_product_guest.sql Merged PR 4124: Adds dedicated start date for KPIs 2025-01-21 11:18:16 +00:00
int_kpis__dimension_dates.sql Merged PR 4124: Adds dedicated start date for KPIs 2025-01-21 11:18:16 +00:00
int_kpis__dimension_deals.sql Addressed comments 2025-03-14 14:20:57 +01:00
int_kpis__lifecycle_daily_accommodation.sql
int_kpis__lifecycle_daily_deal.sql Changes in deals lifecycle 2025-03-14 10:39:01 +01:00
int_kpis__metric_daily_billable_bookings.sql Merged PR 4425: Reworks Billable Bookings metrics 2025-02-17 15:59:21 +00:00
int_kpis__metric_daily_check_in_attributed_guest_journeys.sql Changed to updated_at_utc 2024-11-19 09:23:28 +01:00
int_kpis__metric_daily_check_out_bookings.sql Merged PR 4425: Reworks Billable Bookings metrics 2025-02-17 15:59:21 +00:00
int_kpis__metric_daily_completed_guest_journeys.sql Merged PR 4374: Ensures KYG lite users are excluded from New and Old Dash 2025-02-13 09:38:43 +00:00
int_kpis__metric_daily_created_bookings.sql Merged PR 4374: Ensures KYG lite users are excluded from New and Old Dash 2025-02-13 09:38:43 +00:00
int_kpis__metric_daily_created_guest_journeys.sql Merged PR 4374: Ensures KYG lite users are excluded from New and Old Dash 2025-02-13 09:38:43 +00:00
int_kpis__metric_daily_deals.sql Merged PR 4395: Propagates business scope into Deal/Listing metrics 2025-02-13 16:34:14 +00:00
int_kpis__metric_daily_guest_journeys_with_payment.sql Merged PR 4374: Ensures KYG lite users are excluded from New and Old Dash 2025-02-13 09:38:43 +00:00
int_kpis__metric_daily_guest_payments.sql Merged PR 4374: Ensures KYG lite users are excluded from New and Old Dash 2025-02-13 09:38:43 +00:00
int_kpis__metric_daily_host_resolutions.sql Merged PR 4349: Xero metrics by Business Scope 2025-02-11 15:13:42 +00:00
int_kpis__metric_daily_invoiced_revenue.sql Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 2025-03-18 14:55:32 +00:00
int_kpis__metric_daily_listings.sql Merged PR 4413: Fixes on Business Scope 2025-02-14 16:17:41 +00:00
int_kpis__metric_daily_new_dash_chargeable_services.sql Updated all PK in created and chargeable services models 2024-12-02 12:42:47 +01:00
int_kpis__metric_daily_new_dash_created_services.sql Updated all PK in created and chargeable services models 2024-12-02 12:42:47 +01:00
int_kpis__metric_daily_started_guest_journeys.sql Merged PR 4374: Ensures KYG lite users are excluded from New and Old Dash 2025-02-13 09:38:43 +00:00
int_kpis__metric_monthly_billable_bookings.sql Merged PR 4400: Adds Billable Bookings split per scope 2025-02-14 12:29:18 +00:00
int_kpis__metric_monthly_check_out_bookings.sql Merged PR 4425: Reworks Billable Bookings metrics 2025-02-17 15:59:21 +00:00
int_kpis__metric_monthly_completed_guest_journeys.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_monthly_created_bookings.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_monthly_created_guest_journeys.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_monthly_guest_journeys_with_payment.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_monthly_guest_payments.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_monthly_host_resolutions.sql Merged PR 4357: Propagates in Host Resolutions and Invoiced Revenue the new business scope 2025-02-12 08:17:44 +00:00
int_kpis__metric_monthly_invoiced_revenue.sql Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 2025-03-18 14:55:32 +00:00
int_kpis__metric_monthly_new_dash_chargeable_services.sql Updated all PK in created and chargeable services models 2024-12-02 12:42:47 +01:00
int_kpis__metric_monthly_new_dash_created_services.sql Updated all PK in created and chargeable services models 2024-12-02 12:42:47 +01:00
int_kpis__metric_monthly_started_guest_journeys.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_mtd_billable_bookings.sql Merged PR 4400: Adds Billable Bookings split per scope 2025-02-14 12:29:18 +00:00
int_kpis__metric_mtd_check_out_bookings.sql Merged PR 4425: Reworks Billable Bookings metrics 2025-02-17 15:59:21 +00:00
int_kpis__metric_mtd_completed_guest_journeys.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_mtd_created_bookings.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_mtd_created_guest_journeys.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_mtd_guest_journeys_with_payment.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_mtd_guest_payments.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_mtd_host_resolutions.sql Merged PR 4357: Propagates in Host Resolutions and Invoiced Revenue the new business scope 2025-02-12 08:17:44 +00:00
int_kpis__metric_mtd_invoiced_revenue.sql Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 2025-03-18 14:55:32 +00:00
int_kpis__metric_mtd_started_guest_journeys.sql Merged PR 4352: Bulk update dash_source to business_scope 2025-02-11 16:19:33 +00:00
int_kpis__metric_weekly_new_dash_chargeable_services.sql Updated all PK in created and chargeable services models 2024-12-02 12:42:47 +01:00
int_kpis__metric_weekly_new_dash_created_services.sql Updated all PK in created and chargeable services models 2024-12-02 12:42:47 +01:00
int_kpis__product_guest_agg_metrics.sql
int_kpis__product_guest_daily_metrics.sql
int_kpis__product_new_dash_agg_metrics.sql
schema.yml Merged PR 4727: Bookings fees are now Old Dashboard Booking Fees in Main KPIs 2025-03-18 14:55:32 +00:00