Commit graph

23 commits

Author SHA1 Message Date
Oriol Roqué Paniagua
8bc525e4c2 Merged PR 5589: Limits data test coverage on resolutions data
# Description

This relates to the data alerts on resolutions models.

We have one incident status that refers to the record having missing information. The record that is currently triggering this alerts is indeed tagged as such.

The idea is to:
* Create a new boolean that flags if the incident has missing information. This is propagated stg to reporting.
* Apply a where clause to any existing data alert that might be susceptible to fail due to not having enough quality, in staging and reporting.
* Remove over coverage in intermediate since it's already happening in reporting. However we keep a few not-null tests and the PK on critical information (i.e., id_booking).

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [NA] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #31668
2025-07-01 09:44:54 +00:00
Joaquin
52e351e0ba Fixed tests from resolutions 2025-06-20 10:39:21 +02:00
Joaquin
f482b64528 Removed test 2025-06-11 14:51:20 +02:00
Joaquin Ossa
b20cb44779 Calculator changes 2025-02-28 12:19:24 +01:00
Joaquin Ossa
42701b4d2c Merged PR 4530: first comment time added
# Description

First comment time added

# Checklist

- [x] The edited models and dependants run properly with production data.
- [x] The edited models are sufficiently documented.
- [x] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

first comment time added

Related work items: #27812
2025-02-27 12:28:09 +00:00
Joaquin Ossa
aaa0b1a5dd changed name 2025-02-26 16:45:01 +01:00
Joaquin Ossa
0fd8c21e38 Small changes 2025-02-26 16:22:32 +01:00
Joaquin Ossa
465bd51ff2 Final update 2025-02-26 08:24:50 +01:00
Joaquin Ossa
03955aadd5 Finished schema 2025-02-25 14:54:59 +01:00
Joaquin Ossa
f036e626d7 Commit removed unnecessary fields 2025-02-25 12:19:45 +01:00
Joaquin Ossa
62316778fb updated schema 2025-02-24 16:35:10 +01:00
Joaquin Ossa
1d514cec3a Addressed comments 2025-02-24 16:27:16 +01:00
Joaquin Ossa
34f8fbe499 commit wip 2025-02-24 15:06:55 +01:00
Joaquin Ossa
62c2e44b86 Deduplicated records 2025-02-24 10:57:46 +01:00
Joaquin Ossa
2e19678182 Final tests update 2025-02-23 16:39:43 +01:00
Joaquin Ossa
fb4775bd07 Updated tests 2025-02-23 16:11:37 +01:00
Joaquin Ossa
fc85dd9e70 Fixed data_types and added tests 2025-02-23 16:05:11 +01:00
Joaquin Ossa
d6dcbcc67e commit wip 2025-02-23 15:04:59 +01:00
Joaquin Ossa
f3842c950b commit wip 2025-02-22 19:55:30 +01:00
Joaquin Ossa
9704426dd6 commit wip 2025-02-22 14:16:41 +01:00
Joaquin Ossa
05adc07674 commit wip 2025-02-21 17:44:00 +01:00
Joaquin Ossa
1b853a9503 commit wip (id_incident duplicates have to check) 2025-02-21 16:40:53 +01:00
Joaquin Ossa
725f2a54c3 Staging model for resolution incidents 2025-02-21 15:25:24 +01:00