Commit graph

1701 commits

Author SHA1 Message Date
Joaquin
50650776fc last check 2025-03-26 10:17:41 +01:00
Joaquin
20a277037d Addressed comment 2025-03-26 10:10:51 +01:00
Joaquin
90581ea142 Addressed comments 2025-03-25 17:29:55 +01:00
Joaquin
20a8958679 Commit wip 2025-03-25 17:11:02 +01:00
Joaquin
2c5301c158 commit wip 2025-03-25 12:26:11 +01:00
Joaquin
721f3e4e9e Addressed comments 2025-03-25 12:26:11 +01:00
Joaquin
1ebd1c5ccb Created new kpi daily model for new dash users 2025-03-25 12:26:11 +01:00
Joaquin
c0a1e90fae Improved New Dash Services usage 2025-03-25 12:26:11 +01:00
Pablo Martín
12e0f55b08 Merged PR 4779: Add run step to CI PR
# Description

Adds a run step in PR CI to make it build the models the PR is modifying.

Related work items: #28629
2025-03-25 09:05:23 +00:00
Pablo Martin
5008cb1082 remove silly test changes 2025-03-24 16:32:38 +01:00
Pablo Martin
ddc38ef513 only direct downstream, not all downstream 2025-03-24 16:27:15 +01:00
Pablo Martin
5b6f0a6bc4 trigger a lot of runs 2025-03-24 14:59:06 +01:00
Pablo Martin
18173f7ffd typo 2025-03-24 14:21:05 +01:00
Pablo Martin
db66bb6d97 replace hardcodes 2025-03-24 14:17:02 +01:00
Pablo Martin
e311431fbb also run downstream 2025-03-24 12:22:43 +01:00
Oriol Roqué Paniagua
fae7572777 Merged PR 4782: Dashboard, Pricing and Services from Hubspot
# Description

Brings 3 new properties from HubSpot - Deals:
* Dashboard Type: Old Dash, New Dash or null
* Pricing Structure: this contains several possibilities, such as new pricing v1, v2, old pricing (legacy), api pricing, etc.
* Partnership Services: what services the client has according to Hubspot. Not the best in terms of quality but better than nothing specially in Old Dash. I also handled a small processing since services were differently separated.

This is propagated to intermediate in `int_hubspot__deal`. This is needed to automate the pricing differences for clients in old dash to be moved to new dash.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented. **Mostly on intermediate, did not bother to update staging besides the new fields.**
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #28627
2025-03-24 11:20:03 +00:00
Pablo Martin
f6c1043038 fix identation 2025-03-24 12:16:59 +01:00
Pablo Martin
73f40ff1a5 continue 2025-03-24 12:11:23 +01:00
Pablo Martin
8a4ec6c257 typo 2025-03-24 12:01:53 +01:00
Pablo Martin
75b85073ae typo in macro 2025-03-24 11:58:15 +01:00
Pablo Martin
f2e447ba60 running on pointer database 2025-03-24 11:55:53 +01:00
Pablo Martin
c59600d9f2 another silly change to trigger build 2025-03-24 11:34:13 +01:00
Pablo Martin
8938545d3a add silly change to test ci 2025-03-21 16:58:46 +01:00
Pablo Martin
8666b88953 add run step 2025-03-21 16:53:22 +01:00
Pablo Martin
5860f5b9f6 revert accidental commit, woooops 2025-03-21 16:53:01 +01:00
Pablo Martin
0bf35bf71a Merge branch 'master' of ssh.dev.azure.com:v3/guardhog/Data/data-dwh-dbt-project 2025-03-21 16:52:42 +01:00
Pablo Martin
286a5b5890 add run step 2025-03-21 16:52:39 +01:00
Oriol Roqué Paniagua
780ac25a9a Merged PR 4777: Fix YTD on Revenue Churn Rate. Increase precision with 1 decimal
# Description

Only affects Churn Rate targets: Adds 1 extra decimal. Fixes issue on YTD not computed properly.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Fix YTD on Revenue Churn Rate. Increase precision with 1 decimal

Related work items: #28560
2025-03-21 15:15:21 +00:00
Pablo Martin
dcb1d670a8 add master pipeline 2025-03-21 15:54:49 +01:00
Pablo Martin
a98d8fe41f change yaml name 2025-03-21 15:52:48 +01:00
Pablo Martín
7acf509b03 Merged PR 4771: Only state modified in CI
# Description

Modifies our CI pipeline so that:
- It produces a master-version `manifest.json`.
- It only compiles models that have been modified when compared to the master version.

Related work items: #28629
2025-03-21 14:33:34 +00:00
Pablo Martin
2779a73d10 remove list step 2025-03-21 15:24:32 +01:00
Pablo Martin
dc51c503d0 a couple of small changes 2025-03-21 15:20:37 +01:00
Pablo Martin
30ab85bd24 typo, disable run on every commit 2025-03-21 15:14:53 +01:00
Pablo Martin
682cf592a6 typo 2025-03-21 15:09:47 +01:00
Pablo Martin
eedc5931c7 restrict list 2025-03-21 15:02:47 +01:00
Pablo Martin
229ab901d1 restrict list to models, tests and exposures 2025-03-21 15:02:31 +01:00
Pablo Martin
5d92c43215 add ls step 2025-03-21 14:38:48 +01:00
Pablo Martin
40f28a9411 remove master trigger 2025-03-21 14:25:36 +01:00
Pablo Martin
e0fbf093b8 undo stupid change 2025-03-21 12:33:06 +01:00
Pablo Martin
395c064365 edit one model to test state detection 2025-03-21 12:33:06 +01:00
Pablo Martin
bc7ea8d001 make dbt docs a bit more efficient, hopefully 2025-03-21 12:33:06 +01:00
Pablo Martin
14b927b8d4 typo 2025-03-21 12:33:06 +01:00
Pablo Martin
d26c70bba4 add steps in ci 2025-03-21 12:33:06 +01:00
Oriol Roqué Paniagua
8924778a52 Merged PR 4770: Same freshness in MTD and YTD/target for Resolutions Payouts
# Description

Ensures Resolutions Payouts (in amount paid) is timely

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Same freshness in MTD and YTD/target for Resolutions Payouts

Related work items: #28560
2025-03-21 11:10:26 +00:00
Pablo Martín
36e6a35d12 Merged PR 4753: Add sqlfluff check
# Description

Adds another check to CI that validates that compiled SQL is valid.

Related work items: #28628
2025-03-21 10:10:44 +00:00
Oriol Roqué Paniagua
98c40d21d2 Merged PR 4769: Refactors display exclusion in main metrics
# Description

I noticed this morning that after the name changes some exclusions have been messed up.

I think is about time we handle this properly. Following what we did for `ytd_mtd_aggregated_main_metrics_overview`, I apply the same logic: the metric display configuration is handled for each metric in the configuration rather than by some crazy-complex-name-logic.

I also took the opportunity to make Host Resolutions timely after a discussion with Chloe yesterday. Finance handles resolutions payments twice a week, and the "delay" in time is mostly coming from Resolutions accepting to pay someone vs. Finance handling the payment. In any case we're talking about a few days maximum difference, which I believe it's 1) process-related freshness, rather than data-related and 2) much better to have visibility in a timely manner rather than waiting for the 20th on next month.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs. **Logic is common among YTD and MTD models. At some moment this can be improved**
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #28560
2025-03-21 09:40:20 +00:00
Oriol Roqué Paniagua
240d6ec59e Merged PR 4763: Align metrics within KPIs report
# Description

There's misalignment in the different areas in the business, but even within our own report...

**I'm not saying this is perfect** - but at least it forces a common Data Glossary within Main KPIs. I'd suggest later on reviewing naming - same as we need to do for revenue anyway -, but for the meantime, at least have consistency on our side.

Changes:
* Est. Billable Bookings -> Billable Bookings. We have other metrics stated as Estimated in the Data Glossary.
* Waiver and Resolutions payments to host are now called Payouts. This is not perfect but at least is clear we're paying out, so it's a cost.
* Host Resolutions Payment Rate is now explicitly mentioning how it's being computed to avoid confusion with the Payout Rate, that does not appear here yet, but appears in the YTD.

Additional Changes:
* Tests are also aligned with new names.
* Re-order booking display, so Cancelled Bookings (inclusion and exclusion) are shown below. Having them the first is weird.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #28560
2025-03-20 17:00:36 +00:00
Pablo Martin
6a38a4ec48 modify ugly name 2025-03-20 17:03:13 +01:00
Oriol Roqué Paniagua
6b9434355a Merged PR 4759: Adds Booking Fee per Billable Booking
# Description

Changes:
* Creates Booking Fees in YTD/MTD
* Creates Booking Fees per Billable Booking in YTD/MTD. This is exposed forward.
* Removes code for Onboarding MRR in YTD/MTD.

Additional fixes:
* Small mistake - Revenue Churn is now considered as NEGATIVE

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #28560
2025-03-20 16:01:27 +00:00