Commit graph

1131 commits

Author SHA1 Message Date
Pablo Martin
c23e79b5fe add staging model 2024-06-25 11:04:28 +02:00
Pablo Martin
8fbbb1d10b add source 2024-06-25 11:04:16 +02:00
Oriol Roqué Paniagua
0655ac8997 Merged PR 2105: Adding listing lifecycle metrics into business KPIs
This PR will compute the listing metrics in an aggregated manner to be displayed in the Main KPIs dashboard, specifically:
- New Listings
- First Time Booked Listings
- Churning Listings
- It also adapts the computation for the already existing metrics of Listings Booked in X months

At code level, it contains the following:
- Adds `int_core__mtd_accommodation_metrics`, which computes the aggregation of the lifecycle of listings at date level (unique), being date the corresponding date from `int_dates_mtd`
- Changes `int_core__mtd_aggregated_metrics` to take the accommodation metrics from the new model. Those 3 already existing (Listings booked in X month) now read from the new model as well.
- Changes `int_core__mtd_booking_metrics` to remove unused computation, making it lighter. Specifically, it removes 1) listing related metrics, since now we have a dedicated model and 2) number of guests booked, since it's not used at all.

The resulting values in local are consistent with what is already reported in the staging report.

Related work items: #17312
2024-06-25 08:14:23 +00:00
Oriol Roqué Paniagua
f23e210129 Merged PR 2094: Removing lifecycle logic from int_core__accommodation
Removing lifecycle logic from int_core__accommodation
This logic is now available on int_core__mtd_accommodation_lifecycle

Related work items: #17312
2024-06-21 14:13:42 +00:00
Oriol Roqué Paniagua
ef80637a9b Merged PR 2090: Adding int_core__mtd_accommodation_lifecycle
Adding int_core__mtd_accommodation_lifecycle. Mainly, it recreates the history of the lifecycle of a listing for each date appearing in the MTD dates (so, last day of month + days for current month + days for current month of the previous year).

Implementation of lag function makes it much faster than self-join. Runs in approx 17 seconds (in local)

The logic behind the lifecycle is the same, and the most-up-to-date results in my local show the same values for the new model and the int_core__accommodation model (see screenshots)

previous model:
![image.png](https://guardhog.visualstudio.com/4148d95f-4b6d-4205-bcff-e9c8e0d2ca65/_apis/git/repositories/54ac356f-aad7-46d2-b62c-e8c5b3bb8ebf/pullRequests/2090/attachments/image.png)

new model:
![image (2).png](https://guardhog.visualstudio.com/4148d95f-4b6d-4205-bcff-e9c8e0d2ca65/_apis/git/repositories/54ac356f-aad7-46d2-b62c-e8c5b3bb8ebf/pullRequests/2090/attachments/image%20%282%29.png)

Following PRs will focus on readapting logic of int_core__accommodation to avoid the replication of lifecycle computation (just re-use the last available date in int_core__mtd_accommodation_lifecycle) and the creation of the desired metrics for the Biz Overview dashboard, including a refactor of the mtd_bookings to remove the listing logic from there.

Related work items: #17312
2024-06-21 13:59:14 +00:00
Oriol Roqué Paniagua
fe93f594f5 Merged PR 2084: Adding int_core__accommodation
Adding int_core__accommodation

Includes both:
- Main information of the accommodation, mostly coming from stg_core__accommodation and int_core__country.
- Listing lifecycle computation, based on the created bookings from stg_core__bookings. It's just the current state, no history.

Some considerations:
- I opted to use stg_core__bookings and not int_core__bookings. Main reason is in case at some point we want to add listing-based information to the booking table, it would avoid cyclic references.
- I opted to keep all the logic of 1) accommodation info and 2) lifecycle in the same model. This could be easily split into: lifecycle first that reads uniquely from staging and then the int_core__accommodation that could read from the staging version to retrieve accommodation attributes + the lifecycle one. Up to you

I'd suggest to review first the documentation in schema since it explains the logic applied.

Notion page linked to this task: https://www.notion.so/knowyourguest-superhog/Listing-lifecycle-4dc0311b21ca44f8859969e419872ebd

Related work items: #17312
2024-06-20 16:02:16 +00:00
Pablo Martin
696490aecb docs for bank transactions table 2024-06-20 15:52:55 +02:00
Pablo Martin
26e7358648 credit notes docs 2024-06-20 15:26:33 +02:00
Pablo Martin
e1a4faf3b9 more contact tests 2024-06-20 15:15:19 +02:00
Pablo Martin
7aa667f7cf boy scout: tests for invoices 2024-06-20 15:00:59 +02:00
Pablo Martin
c671701071 boy scout: contact tests 2024-06-20 14:37:55 +02:00
Pablo Martin
79d69a9286 staging model 2024-06-20 14:31:12 +02:00
Pablo Martin
cd9c797f02 add source 2024-06-20 14:12:30 +02:00
Pablo Martin
05f35fcb69 add value to test 2024-06-19 18:25:49 +02:00
Pablo Martin
6ad203b92f add some comments 2024-06-19 18:18:38 +02:00
Oriol Roqué Paniagua
839e5fae1b Merged PR 2077: Adding Country to intermediate
Adding Country to intermediate, both model + documentation.

At this stage, the model is set as a view but we can discuss what is the best approach

Related work items: #17312
2024-06-19 15:34:15 +00:00
Joaquin Ossa
4a80625eeb Merged PR 2064: Created currency exchange tables
Created currency exchange tables in general for new dashboard

Related work items: #17323
2024-06-19 10:01:20 +00:00
Joaquin Ossa
31feff162a Fixed names of tables 2024-06-19 11:59:45 +02:00
Joaquin Ossa
f64b17a223 Created currency exchange tables 2024-06-19 11:52:28 +02:00
Oriol Roqué Paniagua
fb86850ffe Merged PR 2074: Adding country to staging
Adding country to staging

Related work items: #17312
2024-06-19 08:40:08 +00:00
Oriol Roqué Paniagua
771b226888 Merged PR 2068: Adding cancelled bookings metric
Adding cancelled bookings metric based on the feedback of the tech team. Mainly, the date of a cancelled booking can be considered as the `updated_date_utc` for those bookings with status cancelled, as it's a terminal state and no additional steps should follow.

I also took the opportunity to update:
- The order on the `int_core__mtd_aggregated_metrics`, so it matches the one in the Notion page for the 1st batch, freeing already the space for the order_by numbers for missing metrics
- Make acronyms of alias in the `main_kpi` subquery in `int_core__mtd_booking_metrics` slightly more clear
- Remove empty line at the end of the file in `int_core__mtd_booking_metrics`

Keep in mind that the cancelled bookings metric will be directly available in the dashboard once this PR is approved and DWH re-runs.

Related work items: #17310
2024-06-18 14:58:55 +00:00
Pablo Martin
344419e660 formatting 2024-06-18 13:41:32 +02:00
Pablo Martin
3d3f3fb9ab fix docs 2024-06-18 13:40:36 +02:00
Pablo Martin
27759374b8 add docs and tests 2024-06-18 13:10:47 +02:00
Pablo Martin
c051831d6d upper in payments 2024-06-18 13:09:45 +02:00
Pablo Martin
662c7b8ba8 remove hardcoded rates and seed, remove docs 2024-06-18 11:35:07 +02:00
Pablo Martin
8b91babad6 remove old table from cte 2024-06-18 11:31:59 +02:00
Pablo Martin
1f9df9ea5c remove old table 2024-06-18 11:24:03 +02:00
Pablo Martin
d96c8b2abb change which field we join on: payment date is not always informed 2024-06-18 11:23:10 +02:00
Pablo Martin
6f625ec7db do both rates to compare and test 2024-06-18 11:13:51 +02:00
Pablo Martin
e3be2708ad add new rates to CTEs 2024-06-18 11:06:27 +02:00
Oriol Roqué Paniagua
4958976733 Merged PR 2053: Added number_format category in mtd_aggregated_metrics
Added number_format category in mtd_aggregated_metrics

Related work items: #17458
2024-06-17 14:59:01 +00:00
Pablo Martín
a686c16978 Merged PR 2041: Fix Backward Currency Projection Bug
The CTEs that project currency rates backwards have a few mistakes that introduce additional dates in the period where we do have actual, factual rates. This PR fixes the errors that cause this.
2024-06-17 13:42:52 +00:00
uri
c8807ddf60 Adding exposure of main kpis dashboard 2024-06-17 14:04:51 +02:00
Pablo Martin
0606f2c93d go back to var, made a mistake in the last commit 2024-06-17 11:32:20 +02:00
uri
cc930c5202 Extra documentation in the int_core__mtd_aggregated_metrics model 2024-06-17 11:32:13 +02:00
Pablo Martin
1203d0921b use proper table, proper col, and remove off by one error 2024-06-17 11:31:54 +02:00
Pablo Martin
a8892e7d5d this max should have been an int 2024-06-17 11:27:44 +02:00
uri
17f2e92ddc Adding guest journey KPIs. Updating gitignore 2024-06-17 11:10:13 +02:00
Pablo Martin
4c68df570f tests 2024-06-14 16:46:28 +02:00
Pablo Martin
913c07dad6 docs 2024-06-14 16:44:48 +02:00
Pablo Martin
84cd5ed7d0 simple model 2024-06-14 16:44:40 +02:00
Pablo Martin
41a7f7a510 replace hardcode with global var 2024-06-14 16:28:25 +02:00
Pablo Martin
bceb81ea18 more detail in docs 2024-06-14 16:26:18 +02:00
Pablo Martin
d4decdcd8b remove years into the future hardcode 2024-06-14 16:26:18 +02:00
Pablo Martin
2b878e9478 union all instead of union 2024-06-14 16:26:18 +02:00
Pablo Martin
e9ed1cfe02 wrong comment 2024-06-14 16:26:18 +02:00
Pablo Martin
eaeb7cb936 schema and tests for new table 2024-06-14 16:26:18 +02:00
Pablo Martin
15ec3db1f2 fixed off by one errors in date projections 2024-06-14 16:26:18 +02:00
Pablo Martin
9d11aa165b past working 2024-06-14 16:26:18 +02:00