Merged PR 4309: Cancelled Bookings KPIs rework
# Description Exposes new metrics: * Created Bookings (Excl. Cancelled) * Cancelled Created Bookings * Check Out Bookings (Excl. Cancelled) * Cancelled Check Out Bookings Re-naming of existing metrics: * Created Bookings -> Total Created Bookings * Checkout Bookings -> Total Check Out Bookings Removes exposure of previous Cancelled Bookings. In the monthly by deal model, it's hardcoded still - need to change PBI to remove safely. This will be done later on once we remove the Cancelled Bookings models. Adapts the existing tests on KPIs to accommodate for the changes by including new metrics. Also, I've set the detector to 5 (from 8) since it's been a while this has not triggered thus might be worth the effort to have more detection capabilities. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #24637
This commit is contained in:
parent
cc86565b02
commit
fe3a5c9fe9
6 changed files with 155 additions and 87 deletions
|
|
@ -13,8 +13,14 @@ select
|
|||
main_billing_country_iso_3_per_deal as main_billing_country_iso_3_per_deal,
|
||||
deal_lifecycle_state as deal_lifecycle_state,
|
||||
created_bookings as created_bookings,
|
||||
cancelled_created_bookings as cancelled_created_bookings,
|
||||
not_cancelled_created_bookings as not_cancelled_created_bookings,
|
||||
cancelled_created_bookings_rate as cancelled_created_bookings_rate,
|
||||
check_out_bookings as check_out_bookings,
|
||||
cancelled_bookings as cancelled_bookings,
|
||||
cancelled_check_out_bookings as cancelled_check_out_bookings,
|
||||
not_cancelled_check_out_bookings as not_cancelled_check_out_bookings,
|
||||
cancelled_check_out_bookings_rate as cancelled_check_out_bookings_rate,
|
||||
0 as cancelled_bookings, -- to be removed
|
||||
billable_bookings as billable_bookings,
|
||||
created_guest_journeys as created_guest_journeys,
|
||||
started_guest_journeys as started_guest_journeys,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue