From f426825c47e21bf6bc1064eeaaf763eaa314cab7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Tue, 22 Oct 2024 13:06:58 +0000 Subject: [PATCH] Merged PR 3286: Rename of categories for top losers/winners # Description Re-aligned namings with Matt and Alex. This PR just changes the top losers, losers, winners and top winners to major decline, decline, gain and major gain respectively # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [NA] I have checked for DRY opportunities with other models and docs. - [NA] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Rename of categories for top losers/winners Related work items: #23170 --- .../cross/int_monthly_growth_score_by_deal.sql | 8 ++++---- models/intermediate/cross/schema.yml | 8 ++++---- models/reporting/general/schema.yml | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/models/intermediate/cross/int_monthly_growth_score_by_deal.sql b/models/intermediate/cross/int_monthly_growth_score_by_deal.sql index 9047f6a..d834a33 100644 --- a/models/intermediate/cross/int_monthly_growth_score_by_deal.sql +++ b/models/intermediate/cross/int_monthly_growth_score_by_deal.sql @@ -407,15 +407,15 @@ select -- opinionated case when gsc.weighted_avg_growth_score <= -1.0 - then 'TOP LOSER' + then 'MAJOR DECLINE' when gsc.weighted_avg_growth_score > -1.0 and gsc.weighted_avg_growth_score < 0 - then 'LOSER' + then 'DECLINE' when gsc.weighted_avg_growth_score = 0 then 'FLAT' when gsc.weighted_avg_growth_score > 0 and gsc.weighted_avg_growth_score < 1.0 - then 'WINNER' + then 'GAIN' when gsc.weighted_avg_growth_score >= 1.0 - then 'TOP WINNER' + then 'MAJOR GAIN' else 'UNSET' end as categorisation_weighted_avg_growth_score from growth_score_computation gsc diff --git a/models/intermediate/cross/schema.yml b/models/intermediate/cross/schema.yml index 9c49c4e..a51b9c3 100644 --- a/models/intermediate/cross/schema.yml +++ b/models/intermediate/cross/schema.yml @@ -1231,11 +1231,11 @@ models: - not_null - accepted_values: values: - - TOP LOSER - - LOSER + - MAJOR DECLINE + - DECLINE - FLAT - - WINNER - - TOP WINNER + - GAIN + - MAJOR GAIN - UNSET - name: int_monthly_12m_window_contribution_by_deal diff --git a/models/reporting/general/schema.yml b/models/reporting/general/schema.yml index 6338a0f..92cee23 100644 --- a/models/reporting/general/schema.yml +++ b/models/reporting/general/schema.yml @@ -1156,9 +1156,9 @@ models: - not_null - accepted_values: values: - - TOP LOSER - - LOSER + - MAJOR DECLINE + - DECLINE - FLAT - - WINNER - - TOP WINNER + - GAIN + - MAJOR GAIN - UNSET