From cce5d2b9d66f04663250fa0110a70b58a7919743 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Wed, 13 Nov 2024 09:23:42 +0000 Subject: [PATCH] Merged PR 3490: Removal of other_sharing_platform_url # Description Removes other_sharing_platform_url field that will disappear from the backend in the release going out next week. Apparently there's a dependency with a PBI report that uses core__unified_user table, so I just nullified the reporting field. The report is called users_dashboard, which AFAIK is not published anywhere. I wonder if this is one of the it-should-not-exist report. Waiting for tomorrow confirmation with Pablo. Important note: Since this removes fields from staging, which is incremental, we need to trigger a full-refresh for this table. Otherwise execution will fail. # Checklist - [X] The edited models and dependants run properly with production data. - [NA] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [NA] I have checked for DRY opportunities with other models and docs. - [NA] I've picked the right materialization for the affected models. # Other - [X] Check if a full-refresh is required after this PR is merged. **Yes, please refer to my previous comment.** Related work items: #23974 --- models/intermediate/core/int_core__unified_user.sql | 1 - models/reporting/core/core__unified_user.sql | 4 ++-- models/staging/core/stg_core__superhog_user.sql | 2 -- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/models/intermediate/core/int_core__unified_user.sql b/models/intermediate/core/int_core__unified_user.sql index 009f303..65c4a74 100644 --- a/models/intermediate/core/int_core__unified_user.sql +++ b/models/intermediate/core/int_core__unified_user.sql @@ -42,7 +42,6 @@ select su.number_of_properties, su.id_superhog_verified_set, su.platform_comms_recipient, - su.other_sharing_platform_url, su.id_user_verification_status from stg_core__user as u inner join stg_core__superhog_user as su on u.id_user = su.id_superhoguser diff --git a/models/reporting/core/core__unified_user.sql b/models/reporting/core/core__unified_user.sql index 8a5f64f..4905313 100644 --- a/models/reporting/core/core__unified_user.sql +++ b/models/reporting/core/core__unified_user.sql @@ -34,6 +34,6 @@ select number_of_properties as number_of_properties, id_superhog_verified_set as id_superhog_verified_set, platform_comms_recipient as platform_comms_recipient, - other_sharing_platform_url as other_sharing_platform_url, + null as other_sharing_platform_url, id_user_verification_status as id_user_verification_status -from core__unified_user \ No newline at end of file +from core__unified_user diff --git a/models/staging/core/stg_core__superhog_user.sql b/models/staging/core/stg_core__superhog_user.sql index 4a1d8c3..32ba4be 100644 --- a/models/staging/core/stg_core__superhog_user.sql +++ b/models/staging/core/stg_core__superhog_user.sql @@ -22,8 +22,6 @@ with {{ adapter.quote("NumberOfProperties") }} as number_of_properties, {{ adapter.quote("SuperhogVerifiedSetId") }} id_superhog_verified_set, {{ adapter.quote("PlatformCommsRecipient") }} as platform_comms_recipient, - {{ adapter.quote("OtherSharingPlatformUrl") }} - as other_sharing_platform_url, {{ adapter.quote("UserVerificationStatusId") }} as id_user_verification_status, {{ adapter.quote("_airbyte_extracted_at") }} as dwh_loaded_at_date