Merged PR 2236: Refactor of already exposed metrics: listings, deals and guest journeys

Following yesterday's refactor of booking metrics, this PR provides a refactor of already exposed metrics: listings, deals and guest journeys.
-> Data is consistent with values already exposed.

Changes:
- for `int_core__mtd_listing_metrics`, `int_core__mtd_deal_metrics` and `int_core__mtd_guest_journey_metrics`:
1. remove the computation of the previous year metric value and the relative increment (last part of the query)
2. re-apply the formatting
- for `int_mtd_vs_previous_year_metrics`:
1. Reference listings, deals and GJ models
2. Include the metrics for these types in the `plain_kpi_combination` CTE
3. Add the computation of previous year and relative increment using the macro
- for `int_core__mtd_aggregated_metrics`
1. Remove and "hardcode" sources since all metrics now depend exclusively of `int_mtd_vs_previous_year_metrics`

This PR does not alter the exposed metrics in the production report. It does not aim to change the name of the reporting/intermediate models that expose the information, it will be done in a separated PR.
Documentation: https://www.notion.so/knowyourguest-superhog/Refactoring-Business-KPIs-5deb6aadddb34884ae90339402ac16e3

Related work items: #18202
This commit is contained in:
Oriol Roqué Paniagua 2024-07-09 13:00:43 +00:00
parent 409ac47591
commit ca8334f1da
5 changed files with 299 additions and 287 deletions

View file

@ -8,6 +8,15 @@ with
int_core__mtd_booking_metrics as (
select * from {{ ref("int_core__mtd_booking_metrics") }}
),
int_core__mtd_guest_journey_metrics as (
select * from {{ ref("int_core__mtd_guest_journey_metrics") }}
),
int_core__mtd_accommodation_metrics as (
select * from {{ ref("int_core__mtd_accommodation_metrics") }}
),
int_core__mtd_deal_metrics as (
select * from {{ ref("int_core__mtd_deal_metrics") }}
),
int_dates_mtd as (select * from {{ ref("int_dates_mtd") }}),
plain_kpi_combination as (
@ -18,12 +27,55 @@ with
d.is_end_of_month,
d.is_current_month,
d.date,
-- BOOKINGS --
bookings.created_bookings,
bookings.check_out_bookings,
bookings.cancelled_bookings
bookings.cancelled_bookings,
-- GUEST JOURNEYS --
guest_journeys.created_guest_journeys,
guest_journeys.started_guest_journeys,
guest_journeys.completed_guest_journeys,
guest_journeys.paid_guest_journeys,
guest_journeys.start_rate_guest_journey,
guest_journeys.completion_rate_guest_journey,
guest_journeys.incompletion_rate_guest_journey,
guest_journeys.payment_rate_guest_journey,
-- DEALS --
deals.new_deals,
deals.never_booked_deals,
deals.first_time_booked_deals,
deals.active_deals,
deals.churning_deals,
deals.inactive_deals,
deals.reactivated_deals,
deals.deals_booked_in_month,
deals.deals_booked_in_6_months,
deals.deals_booked_in_12_months,
-- LISTINGS (ACCOMMODATIONS) --
accommodations.new_listings,
accommodations.never_booked_listings,
accommodations.first_time_booked_listings,
accommodations.active_listings,
accommodations.churning_listings,
accommodations.inactive_listings,
accommodations.reactivated_listings,
accommodations.listings_booked_in_month,
accommodations.listings_booked_in_6_months,
accommodations.listings_booked_in_12_months
from int_dates_mtd d
left join int_core__mtd_booking_metrics bookings
on d.date = bookings.date
left join int_core__mtd_guest_journey_metrics guest_journeys
on d.date = guest_journeys.date
left join int_core__mtd_accommodation_metrics accommodations
on d.date = accommodations.date
left join int_core__mtd_deal_metrics deals
on d.date = deals.date
)
select
current.year,
@ -37,7 +89,41 @@ select
-- BOOKINGS --
{{ calculate_safe_relative_increment('created_bookings') }},
{{ calculate_safe_relative_increment('check_out_bookings') }},
{{ calculate_safe_relative_increment('cancelled_bookings') }}
{{ calculate_safe_relative_increment('cancelled_bookings') }},
-- GUEST JOURNEYS --
{{ calculate_safe_relative_increment('created_guest_journeys') }},
{{ calculate_safe_relative_increment('started_guest_journeys') }},
{{ calculate_safe_relative_increment('completed_guest_journeys') }},
{{ calculate_safe_relative_increment('paid_guest_journeys') }},
{{ calculate_safe_relative_increment('start_rate_guest_journey') }},
{{ calculate_safe_relative_increment('completion_rate_guest_journey') }},
{{ calculate_safe_relative_increment('incompletion_rate_guest_journey') }},
{{ calculate_safe_relative_increment('payment_rate_guest_journey') }},
-- DEALS --
{{ calculate_safe_relative_increment('new_deals') }},
{{ calculate_safe_relative_increment('never_booked_deals') }},
{{ calculate_safe_relative_increment('first_time_booked_deals') }},
{{ calculate_safe_relative_increment('active_deals') }},
{{ calculate_safe_relative_increment('churning_deals') }},
{{ calculate_safe_relative_increment('inactive_deals') }},
{{ calculate_safe_relative_increment('reactivated_deals') }},
{{ calculate_safe_relative_increment('deals_booked_in_month') }},
{{ calculate_safe_relative_increment('deals_booked_in_6_months') }},
{{ calculate_safe_relative_increment('deals_booked_in_12_months') }},
-- LISTINGS --
{{ calculate_safe_relative_increment('new_listings') }},
{{ calculate_safe_relative_increment('never_booked_listings') }},
{{ calculate_safe_relative_increment('first_time_booked_listings') }},
{{ calculate_safe_relative_increment('active_listings') }},
{{ calculate_safe_relative_increment('churning_listings') }},
{{ calculate_safe_relative_increment('inactive_listings') }},
{{ calculate_safe_relative_increment('reactivated_listings') }},
{{ calculate_safe_relative_increment('listings_booked_in_month') }},
{{ calculate_safe_relative_increment('listings_booked_in_6_months') }},
{{ calculate_safe_relative_increment('listings_booked_in_12_months') }}
from plain_kpi_combination current
left join plain_kpi_combination previous_year