From c613d2859f399ee98d01b6a23a794db68868bfee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Tue, 27 Aug 2024 09:34:07 +0000 Subject: [PATCH] Merged PR 2648: Fixes int_dates_by_deal tests # Description Fixes int_dates_by_deal tests # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #20318, #20319 --- models/intermediate/cross/schema.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/models/intermediate/cross/schema.yml b/models/intermediate/cross/schema.yml index 8eb8a5e..aa0725b 100644 --- a/models/intermediate/cross/schema.yml +++ b/models/intermediate/cross/schema.yml @@ -268,17 +268,11 @@ models: tests: - not_null - - name: is_end_of_month - data_type: boolean - description: Is end of month, 1 for yes, 0 for no. - tests: - - not_null - - - name: is_current_month - data_type: boolean + - name: last_day_month + data_type: date description: | - Checks if the date is within the current executed month, - 1 for yes, 0 for no. + Last day of the month correspoding to the date field. + It comes from int_dates_mtd logic. tests: - not_null