Merged PR 3605: Beautification of Reporting String values

# Description

Creates a macro for beautification of categorical values.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #20809
This commit is contained in:
Oriol Roqué Paniagua 2024-11-20 11:01:22 +00:00
parent 86c81c1f21
commit c23380583b
3 changed files with 17 additions and 13 deletions

View file

@ -20,6 +20,10 @@ It provides a proper display name for reporting purposes.
{{ return(dimensions) }} {{ return(dimensions) }}
{% endmacro %} {% endmacro %}
{% macro capitalise_and_remove_underscores(field_name) %}
initcap(regexp_replace({{ field_name }}, '_', ' ', 'g'))
{% endmacro %}
/* /*
The following lines specify for each dimension the field to be used in a The following lines specify for each dimension the field to be used in a
standalone macro. standalone macro.

View file

@ -4,9 +4,9 @@ with
) )
select select
date as date, date as date,
time_granularity as time_granularity, {{ capitalise_and_remove_underscores("time_granularity") }} as time_granularity,
dimension as dimension, {{ capitalise_and_remove_underscores("dimension") }} as dimension,
dimension_value as dimension_value, {{ capitalise_and_remove_underscores("dimension_value") }} as dimension_value,
created_services as created_services, created_services as created_services,
booking_with_created_services_count as booking_with_created_services_count booking_with_created_services_count as booking_with_created_services_count
from int_kpis__product_new_dash_agg_metrics from int_kpis__product_new_dash_agg_metrics

View file

@ -233,8 +233,8 @@ models:
tests: tests:
- accepted_values: - accepted_values:
values: values:
- daily - Daily
- monthly - Monthly
- name: dimension - name: dimension
data_type: string data_type: string
@ -242,14 +242,14 @@ models:
tests: tests:
- accepted_values: - accepted_values:
values: values:
- global - "Global"
- by_number_of_listings - "By Number Of Listings"
- by_billing_country - "By Billing Country"
- by_deal - "By Deal"
- by_new_dash_version - "By New Dash Version"
- by_has_upgraded_service - "By Has Upgraded Service"
- by_service - "By Service"
- by_host - "By Host"
- name: dimension_value - name: dimension_value
data_type: string data_type: string