counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 4411: Propagates New Dash/Old Dash/APIs split in KPIs as per Business Scope

Browse source 
# Description

Changes:
* Adapt business_kpis_configuration to include By Business Scope as production dimension.
* Sets in int_mtd_metrics_vs_previous_year the selection of business scope dimension for all KPIs models. This does not affect cross kpis models (churn/mrr). I might need to check later how to adapt Churn to include this dimension, but it's not considered as for this PR. Lastly, Billable Bookings excludes New Dash.
* Adapts condition in int_mtd_metrics_vs_previous_year so MTD values would appear independently of these appearing in the previous year. This is, the model was considering that to show current month MTD values, the dimension needed to exist the year prior. This does not happen with New Dash and I assume we never noticed because in any case, most of our dimensions have quite a long history.
* Adapts int_kpis__agg_dates_main_kpis to include the business scope dimension. By the way it's actually handled, it kind of assumes that a Deal can only be in New or Old Dash (this is correct), but while on New Dash, this deal won't have data for Old Dash (this might not be 100% correct). In any case, the global figure should be ok, and only on the deal + business scope dimensionality this could cause some potential problems. However, this is not being reported anyway at the moment.
* Adapts int_kpis__agg_dates_main_kpis to have a proper variable value for the dimensions, and this is further included in business_kpis_configuration as any other model.

Small changes:
* Adapts Churn metrics to read from dimension_deals rather than core__deals. This should be more accurate anyway.

# Checklist

- [ ] The edited models and dependants run properly with production data.
- [ ] The edited models are sufficiently documented.
- [ ] The edited models contain PK tests, and I've ran and passed them.
- [ ] I have checked for DRY opportunities with other models and docs.
- [ ] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Propagates New Dash/Old Dash/APIs split in KPIs as per Business Scope

Related work items: #27356
This commit is contained in:
Oriol Roqué Paniagua 2025-02-14 14:12:39 +00:00
parent 7f9ff85b44
commit be0b8c41b6
6 changed files with 54 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

19
models/intermediate/kpis/int_kpis__agg_dates_main_kpis.sql
View file

@ -1,4 +1,4 @@
{% set dimensions = get_kpi_dimensions_per_model("") %}
{% set dimensions = get_kpi_dimensions_per_model("MAIN_KPIS_DATES") %}
{{ config(materialized="table", unique_key=["date", "dimension", "dimension_value"]) }}
@ -11,6 +11,20 @@ with
ikdd.date,
-- Dimensions --
coalesce(ikd_deals.id_deal, 'UNSET') as id_deal,
case
when ikd_deals.client_type = 'API'
then 'API'
when ikd_deals.client_type = 'PLATFORM'
then
case
when
icnddsd.id_deal is not null
and ikdd.date >= icnddsd.min_user_in_new_dash_since_date_utc
then 'New Dash'
else 'Old Dash'
end
else 'UNSET'
end as business_scope,
coalesce(
ikd_deals.main_billing_country_iso_3_per_deal, 'UNSET'
) as main_billing_country_iso_3_per_deal,
@ -32,6 +46,9 @@ with
{{ ref("int_kpis__dimension_daily_accommodation") }} as icmas
on ikd_deals.id_deal = icmas.id_deal
and ikdd.date = icmas.date
left join
{{ ref("int_core__new_dash_deal_since_date") }} as icnddsd
on ikd_deals.id_deal = icnddsd.id_deal
where (ikdd.is_month_to_date = true or ikdd.is_end_of_month)
)