Addressed comments

This commit is contained in:
Joaquin Ossa 2025-02-19 16:37:40 +01:00
parent c710de7117
commit b35d9b0a00
4 changed files with 11 additions and 18 deletions

View file

@ -10,9 +10,6 @@ with
select
bts.id_booking,
bts.id_verification_request,
case
when bts.id_verification_request is null then false else true
end as has_verification_request,
bts.id_accommodation,
bts.id_user_product_bundle,
bts.id_deal,
@ -88,6 +85,9 @@ select
then true
else false
end as is_booking_cancelled,
case
when bts.id_verification_request is null then false else true
end as has_verification_request,
case
when sum(case when bsd.is_paid_service then 1 else 0 end) > 0
then true

View file

@ -4033,14 +4033,6 @@ models:
The identifier of the verification request. It acts as Foreign Key to
Verification Request table. It can be null.
- name: has_verification_request
data_type: boolean
description: |
Flag to identify if the booking has a verification request or not.
Cannot be null.
data_tests:
- not_null
- name: id_accommodation
data_type: bigint
description:
@ -4317,6 +4309,14 @@ models:
description: |
Flag to identify if the booking has been cancelled or not.
- name: has_verification_request
data_type: boolean
description: |
Flag to identify if the booking has a verification request or not.
Cannot be null.
data_tests:
- not_null
- name: has_paid_services
data_type: boolean
description: |

View file

@ -5,7 +5,6 @@ with
select
b.id_booking as id_booking,
b.id_verification_request as id_verification_request,
b.has_verification_request as has_verification_request,
b.id_deal as id_deal,
d.main_deal_name as main_deal_name,

View file

@ -1250,12 +1250,6 @@ models:
- not_null
- unique
- name: id_verification_request
data_type: bigint
description:
The identifier of the verification request. It acts as Foreign Key to
Verification Request table. It can be null.
- name: has_verification_request
data_type: boolean
description: |