Merged PR 3625: Excludes new dash users without id deal
# Description This PR has 2 commits: - The first one handles the removal from the computation any user that has not an id deal properly set. I just created a boolean field in int_core__user_host that identifies if the host has no id_deal. Then apply the new condition in the 2 main usages of New Dash info. - The second one cleans New Dash KPIs. Since we do not have anymore users without deals, it means that the identification of the host/account is going to be exactly the same if done by id_user_host or id_deal. I hated having id_user_host in KPIs so I've removed it :) Lastly, this should speed up massively the execution. Not because there's improvements on the code but rather the reduction of data. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #20809
This commit is contained in:
parent
2e7c85d11b
commit
b0bed479c7
9 changed files with 16 additions and 39 deletions
|
|
@ -65,9 +65,6 @@ Please note that strings should be encoded with " ' your_value_here ' ",
|
|||
{% macro dim_has_id_check() %}
|
||||
{{ return({"dimension": "'by_has_id_check'", "dimension_value": "has_id_check"}) }}
|
||||
{% endmacro %}
|
||||
{% macro dim_host() %}
|
||||
{{ return({"dimension": "'by_host'", "dimension_value": "id_user_host"}) }}
|
||||
{% endmacro %}
|
||||
{% macro dim_has_upgraded_service() %}
|
||||
{{
|
||||
return(
|
||||
|
|
@ -143,7 +140,6 @@ Provides a general assignement for the Dimensions available for each KPI
|
|||
|
||||
{% if entity_name == "NEW_DASH_CREATED_SERVICES" %}
|
||||
{% set additional_dimensions = additional_dimensions + [
|
||||
dim_host(),
|
||||
dim_has_upgraded_service(),
|
||||
dim_new_dash_version(),
|
||||
dim_pricing_service(),
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue