From a8892e7d5d0e37ad1e541af68f5299689d29eb54 Mon Sep 17 00:00:00 2001 From: Pablo Martin Date: Mon, 17 Jun 2024 11:27:44 +0200 Subject: [PATCH 1/3] this max should have been an int --- models/intermediate/cross/int_daily_currency_exchange_rates.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/intermediate/cross/int_daily_currency_exchange_rates.sql b/models/intermediate/cross/int_daily_currency_exchange_rates.sql index bb5eb88..8551c7f 100644 --- a/models/intermediate/cross/int_daily_currency_exchange_rates.sql +++ b/models/intermediate/cross/int_daily_currency_exchange_rates.sql @@ -64,7 +64,7 @@ with ), -- CTEs for projecting backward oldest_xe_date_per_curr_pair as ( - select from_currency, to_currency, max(rate_date_utc) as oldest_date_utc + select from_currency, to_currency, min(rate_date_utc) as oldest_date_utc from stg_xedotcom__exchange_rates group by 1, 2 ), From 1203d0921bff53bc7facd7d8648a4ae90e362cc0 Mon Sep 17 00:00:00 2001 From: Pablo Martin Date: Mon, 17 Jun 2024 11:31:54 +0200 Subject: [PATCH 2/3] use proper table, proper col, and remove off by one error --- .../cross/int_daily_currency_exchange_rates.sql | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/models/intermediate/cross/int_daily_currency_exchange_rates.sql b/models/intermediate/cross/int_daily_currency_exchange_rates.sql index 8551c7f..01c9e52 100644 --- a/models/intermediate/cross/int_daily_currency_exchange_rates.sql +++ b/models/intermediate/cross/int_daily_currency_exchange_rates.sql @@ -82,12 +82,11 @@ with from generate_series ( - {{ var("start_date") }}::timestamp, + '2020-01-01'::timestamp, ( - select max(most_recent_date_utc) - from most_recent_xe_date_per_curr_pair + select min(oldest_date_utc) from oldest_xe_date_per_curr_pair )::timestamp - - interval '2 days', -- we don't want to pick the last real day, + - interval '1 days', -- we don't want to pick the last real day, '1 day'::interval ) day_series ), From 0606f2c93d96f9d1cdf27166bedad3a233e022e9 Mon Sep 17 00:00:00 2001 From: Pablo Martin Date: Mon, 17 Jun 2024 11:32:20 +0200 Subject: [PATCH 3/3] go back to var, made a mistake in the last commit --- models/intermediate/cross/int_daily_currency_exchange_rates.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/intermediate/cross/int_daily_currency_exchange_rates.sql b/models/intermediate/cross/int_daily_currency_exchange_rates.sql index 01c9e52..590b3e6 100644 --- a/models/intermediate/cross/int_daily_currency_exchange_rates.sql +++ b/models/intermediate/cross/int_daily_currency_exchange_rates.sql @@ -82,7 +82,7 @@ with from generate_series ( - '2020-01-01'::timestamp, + {{ var("start_date") }}::timestamp, ( select min(oldest_date_utc) from oldest_xe_date_per_curr_pair )::timestamp