Merged PR 4769: Refactors display exclusion in main metrics
# Description I noticed this morning that after the name changes some exclusions have been messed up. I think is about time we handle this properly. Following what we did for `ytd_mtd_aggregated_main_metrics_overview`, I apply the same logic: the metric display configuration is handled for each metric in the configuration rather than by some crazy-complex-name-logic. I also took the opportunity to make Host Resolutions timely after a discussion with Chloe yesterday. Finance handles resolutions payments twice a week, and the "delay" in time is mostly coming from Resolutions accepting to pay someone vs. Finance handling the payment. In any case we're talking about a few days maximum difference, which I believe it's 1) process-related freshness, rather than data-related and 2) much better to have visibility in a timely manner rather than waiting for the 20th on next month. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [ ] I have checked for DRY opportunities with other models and docs. **Logic is common among YTD and MTD models. At some moment this can be improved** - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #28560
This commit is contained in:
parent
240d6ec59e
commit
98c40d21d2
3 changed files with 99 additions and 42 deletions
|
|
@ -281,6 +281,20 @@ models:
|
|||
order for displaying purposes. Null values are accepted, but keep
|
||||
in mind that then there's no default controlled display order.
|
||||
|
||||
- name: display_exclusion
|
||||
data_type: string
|
||||
description: |
|
||||
Category to indicate if the metric requires a certain exclusion due
|
||||
to relying on not timely information.
|
||||
This will limit the display for reporting purposes.
|
||||
data_tests:
|
||||
- not_null
|
||||
- accepted_values:
|
||||
values:
|
||||
- NONE
|
||||
- INVOICING
|
||||
- ONGOING_MONTH
|
||||
|
||||
- name: number_format
|
||||
data_type: text
|
||||
description: allows for grouping and formatting for displaying purposes.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue