Merged PR 4425: Reworks Billable Bookings metrics

# Description

Changes:
* On Est. Billable Bookings, keeps previous logic for Old Dash while assuming the first billable service for New Dash
* Adds a Billable Check Out Bookings in Check Out bookings, as defined in the requirements.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #27619
This commit is contained in:
Oriol Roqué Paniagua 2025-02-17 15:59:21 +00:00
parent a3793121af
commit 9540f18562
11 changed files with 110 additions and 24 deletions

View file

@ -1,24 +1,10 @@
{{ config(materialized="table", unique_key=["date", "id_deal", "business_scope"]) }}
-- OLD DASH --
select
-- Unique Key --
icb.booking_fee_charge_date_utc as date,
coalesce(icuh.id_deal, 'UNSET') as id_deal,
-- ORP here: I'm expecting this to change according to the definition of Billable
-- Bookings expected for New Dash. This is just a temporary placeholder in the
-- same fashion as Booking metrics.
case
-- New Dash users with a booking and a deal
when
icbs.id_booking is not null
and icbs.is_user_in_new_dash = true
and icbs.is_missing_id_deal = false
then 'New Dash'
-- Old Dash users if there is no booking or the user is not in the new dash
when icbs.id_booking is null or icbs.is_user_in_new_dash = false
then 'Old Dash'
-- Rest of the cases, includes KYG Lite users
else 'UNSET'
end as business_scope,
'Old Dash' as business_scope,
-- Dimensions --
coalesce(
icd.main_billing_country_iso_3_per_deal, 'UNSET'
@ -38,5 +24,38 @@ left join
and icb.booking_fee_charge_date_utc = icmas.date
left join
{{ ref("int_core__booking_summary") }} as icbs on icb.id_booking = icbs.id_booking
where icb.is_duplicate_booking = false and icb.booking_fee_charge_date_utc is not null
where
icb.is_duplicate_booking = false
and icb.booking_fee_charge_date_utc is not null
-- Exclude any New Dash bookings
and (icbs.id_booking is null or icbs.is_user_in_new_dash = false)
group by 1, 2, 3, 4, 5
union all
-- NEW DASH --
select
-- Unique Key --
icbs.service_first_billable_date_utc as date,
icbs.id_deal,
'New Dash' as business_scope,
-- Dimensions --
coalesce(
icd.main_billing_country_iso_3_per_deal, 'UNSET'
) as main_billing_country_iso_3_per_deal,
coalesce(
icmas.active_accommodations_per_deal_segmentation, 'UNSET'
) as active_accommodations_per_deal_segmentation,
-- Metrics --
count(distinct icbs.id_booking) as billable_bookings
from {{ ref("int_core__booking_summary") }} icbs
left join {{ ref("int_core__deal") }} as icd on icbs.id_deal = icd.id_deal
left join
{{ ref("int_kpis__dimension_daily_accommodation") }} as icmas
on icbs.id_deal = icmas.id_deal
and icbs.service_first_billable_date_utc = icmas.date
where
icbs.is_user_in_new_dash = true
and icbs.is_missing_id_deal = false
and icbs.is_booking_billable = true
group by 1, 2, 3, 4, 5