From 900c73b0763bd9cce329b4456f68518d437d2b05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Mon, 7 Jul 2025 12:53:52 +0000 Subject: [PATCH] Merged PR 5632: Resolution incidents in status Incomplete now have reduced test coverage # Description Resolution incidents in status Incomplete now have reduced test coverage. This fixes today's data alert. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [ ] I have checked for DRY opportunities with other models and docs. - [ ] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #31843 --- models/staging/resolutions/stg_resolutions__incidents.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/models/staging/resolutions/stg_resolutions__incidents.sql b/models/staging/resolutions/stg_resolutions__incidents.sql index cc77e30..da492d3 100644 --- a/models/staging/resolutions/stg_resolutions__incidents.sql +++ b/models/staging/resolutions/stg_resolutions__incidents.sql @@ -8,7 +8,7 @@ {% set tests_or_cancelled_incidents = "ARCHIVED" %} -- Some incidents have insufficient details which might create data quality issues. -{% set insufficient_details_incidents = "INSUFFICIENT DETAILS" %} +{% set insufficient_details_incidents = ("INSUFFICIENT DETAILS", "INCOMPLETE") %} with raw_incident as (select * from {{ source("resolutions", "incident") }}), @@ -21,7 +21,7 @@ select {{ adapter.quote("documents") }} ->> 'VerificationId' as id_verification, {{ adapter.quote("documents") }} ->> 'CurrentStatusName' as current_status_name, upper({{ adapter.quote("documents") }} ->> 'CurrentStatusName') - = '{{ insufficient_details_incidents }}' as is_incident_missing_details, + in {{ insufficient_details_incidents }} as is_incident_missing_details, ({{ adapter.quote("documents") }} ->> 'IsSubmissionComplete')::boolean as is_submission_complete, {{ adapter.quote("documents") }} ->> 'CurrentAgentName' as current_agent_name,