counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 3761: Remove no longer existing fields from Accommodation

Browse source 
# Description

This PR aims to properly fix the Accommodation removal of fields that have been dropped today.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [NA] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [NA] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #25199
This commit is contained in:
Oriol Roqué Paniagua 2024-12-03 16:39:05 +00:00
parent e8f7278032
commit 896526fe15
3 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
models/staging/core/stg_core__accommodation.sql
View file

@ -12,12 +12,6 @@ with
{{ adapter.quote("Postcode") }} as postcode,
{{ adapter.quote("AddressLine1") }} as address_line_1,
{{ adapter.quote("AddressLine2") }} as address_line_2,
-- ORP here. I promise I'll fix this properly. This is just to avoid
-- breaking any DWH execution moving forward after the drop of these
-- fields in the backend.
-- We really need some data contracts...............................
null as verification_level,
null as number_of_floors,
{{ adapter.quote("NumberOfBedrooms") }} as number_of_bedrooms,
{{ adapter.quote("NumberOfBathrooms") }} as number_of_bathrooms,
{{ adapter.quote("CreatedDate") }} as created_at_utc,