Merged PR 2615: Beautification of KPIs dimensions
# Description Changes: * Separate 1) the internal naming of dimensions available within DWH vs. 2) the display of the dimensions in the reporting. Mainly it changes the "by_number_of_listings" to display "By # of Listings Booked in 12 Months". I edited the production macro since to me it's linked to when things are available for display. * Add preceding zeros on the segmentation so it's ordered correctly. Before, the segment 21-60 was displayed before the 6-20. * Also added some capital letters to the schema config of the reporting model :) I attach a screenshot of how it looks in PBI in my local development branch to exemplify why this is "Beautification". Be aware that merging this also puts in production the dimensions.  # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #19325
This commit is contained in:
parent
83d913f9fc
commit
85131985d8
5 changed files with 51 additions and 32 deletions
|
|
@ -1,12 +1,26 @@
|
|||
{% set production_dimensions = get_kpi_dimensions_for_production() %}
|
||||
|
||||
with
|
||||
dimensions as (
|
||||
{% for dimension in production_dimensions %}
|
||||
select
|
||||
{{ dimension.dimension }} as dimension,
|
||||
{{ dimension.dimension_display }} as dimension_display
|
||||
{% if not loop.last %}
|
||||
union all
|
||||
{% endif %}
|
||||
{% endfor %}
|
||||
),
|
||||
int_mtd_aggregated_metrics as (
|
||||
select * from {{ ref("int_mtd_aggregated_metrics") }}
|
||||
select
|
||||
m.*,
|
||||
d.dimension_display
|
||||
from {{ ref("int_mtd_aggregated_metrics") }} m
|
||||
-- The following clause limits the display execution
|
||||
-- to only include those dimensions configured to
|
||||
-- appear for production purposes
|
||||
where dimension in ({{ production_dimensions }})
|
||||
inner join dimensions d
|
||||
on m.dimension = d.dimension
|
||||
)
|
||||
|
||||
select
|
||||
|
|
@ -17,7 +31,7 @@ select
|
|||
is_current_month as is_current_month,
|
||||
first_day_month as first_day_month,
|
||||
date as date,
|
||||
dimension as dimension,
|
||||
dimension_display as dimension,
|
||||
dimension_value as dimension_value,
|
||||
previous_year_date as previous_year_date,
|
||||
order_by as order_by,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue