Merged PR 2615: Beautification of KPIs dimensions
# Description Changes: * Separate 1) the internal naming of dimensions available within DWH vs. 2) the display of the dimensions in the reporting. Mainly it changes the "by_number_of_listings" to display "By # of Listings Booked in 12 Months". I edited the production macro since to me it's linked to when things are available for display. * Add preceding zeros on the segmentation so it's ordered correctly. Before, the segment 21-60 was displayed before the 6-20. * Also added some capital letters to the schema config of the reporting model :) I attach a screenshot of how it looks in PBI in my local development branch to exemplify why this is "Beautification". Be aware that merging this also puts in production the dimensions.  # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #19325
This commit is contained in:
parent
83d913f9fc
commit
85131985d8
5 changed files with 51 additions and 32 deletions
|
|
@ -20,12 +20,15 @@ Macro: get_kpi_dimensions_for_production
|
|||
|
||||
Provides the list of Dimensions that will be available in production for the KPIs.
|
||||
This configuration ensures that working with new dimensions won't affect the display
|
||||
until all development work has been done.
|
||||
until all development work has been done.
|
||||
Additionally, it provides a proper display name for reporting purposes.
|
||||
|
||||
To be added: 'by_number_of_listings'
|
||||
{"dimension": "'by_number_of_listings'", "dimension_display": "'By # of Listings Booked in 12 Months'"}
|
||||
*/
|
||||
|
||||
{% macro get_kpi_dimensions_for_production() %}
|
||||
{% set dimensions = "('global')" %}
|
||||
{% set dimensions = [
|
||||
{"dimension": "'global'", "dimension_display": "'Global'"}
|
||||
] %}
|
||||
{{ return(dimensions) }}
|
||||
{% endmacro %}
|
||||
Loading…
Add table
Add a link
Reference in a new issue